Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
location/index.web.js
socket/SocketTask.js
socket/index.web.js
set-navigation-bar/index.web.js
querySelector 查找已有标签,不存在时才创建
create-intersection-observer/IntersectionObserver.js
this._isInit
system/index.ios.js
原来部分 off 方法不传 callback 时行为不一致或无效,统一对齐微信规范(不传 = 移除全部):
涉及文件:app/index.web.js 补全了
offUnhandledRejection、offError、offAppShow、offAppHide、offLazyLoadError;window/index.web.js 和 rnWindow.js 补全了 web
和 RN 两端的 offWindowResize;keyboard/index.ios.js 补全了
offKeyboardHeightChange;device/network/onNetworkStatusChange.js 补全了 web 端的
offNetworkStatusChange,同时修复了单个移除时遗漏 fnMap.delete 的问题;rnNetwork.js 将 RN 端 offNetworkStatusChange
的空参判断从 === undefined 改为 == null,与 null 传参场景对齐。
原实现用单个 audio.cb 属性共享所有事件回调,多次注册会互相覆盖,且 offXxx 逻辑基本失效。重写为:
原来直接调用异步方法(AsyncStorage.removeItem/clear),同步语义完全错误;修正为 envError 占位,明确告知不支持