feat(i18n): default to Simplified Chinese when system language is zh - #3407
Open
988hj7tczd-oss wants to merge 1 commit into
Open
feat(i18n): default to Simplified Chinese when system language is zh#3407988hj7tczd-oss wants to merge 1 commit into
988hj7tczd-oss wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
@988hj7tczd-oss is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @benjaminshafii 👋 Small follow-up on this one: when no stored language preference exists, Let me know if anything needs adjusting. Thanks! |
When no stored language preference exists, initLocale currently always returns "en". This makes first-run Chinese users see an English UI even though a complete Simplified Chinese translation is shipped. Follow the browser/system language instead: if it starts with "zh", default to "zh" (Simplified Chinese), otherwise fall back to "en". Users can still switch manually via Settings > Appearance > Language, and the stored preference always takes priority.
988hj7tczd-oss
force-pushed
the
i18n/default-zh-locale
branch
from
August 1, 2026 09:26
dce0bba to
212b1ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When no stored language preference exists,
initLocalecurrently always returns"en". This makes first-run Chinese users see an English UI even though a complete Simplified Chinese translation ships with the app.This change follows the browser/system language instead: if it starts with
zh, default tozh(Simplified Chinese); otherwise fall back toen.openwork.language) always takes priorityOnly
apps/app/src/i18n/index.tsis modified (11 insertions). No other files touched.