chore(dor): drop unused ppid from ambient process declaration - #359
Open
dormouse-bot wants to merge 1 commit into
Open
chore(dor): drop unused ppid from ambient process declaration#359dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
Deploying mouseterm with
|
| Latest commit: |
3fe310b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8c23805d.mouseterm.pages.dev |
| Branch Preview URL: | https://chore-drop-dead-ppid-decl.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly survey finding.
The ambient
processdeclaration indor/src/node-runtime.d.tsdeclaresppid: number, but nothing indor/reads.ppid—grep -rn 'ppid' dor/matches only the declaration line itself. Every other member of the ambient declarations is consumed (platform,cwd(), thenode:net/node:fs/node:pathmembers, the timers), so this is the lone dead entry. Removing it.No test is added: this is a type-declaration-only change with no runtime behavior, and the
dorbuild (tsc -p tsconfig.json) is the check that would have caught a stray reference — none exists.