Update README to use default export and destructure on default export.#555
Open
Update README to use default export and destructure on default export.#555
Conversation
dlongley
reviewed
Jun 19, 2024
Member
dlongley
left a comment
dlongley
left a comment
There was a problem hiding this comment.
@davidlehn, is this going to change right back in the imminent next release? If so, let's not make this change, otherwise, +1.
Contributor
|
@davidlehn the CommonJS lines of code in this PR are wrong, but the need is real since I know you have preferences about no CJS stuff in the readme, but would you support a fix for these lines if I keep this using ESM? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the README so the es6 import examples work.