Skip to content

2.0.1#307

Merged
digitalghost-dev merged 5 commits into
mainfrom
2.0.1
Jun 24, 2026
Merged

2.0.1#307
digitalghost-dev merged 5 commits into
mainfrom
2.0.1

Conversation

@digitalghost-dev

@digitalghost-dev digitalghost-dev commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features

    • Added a “back” option to the tournament flow, including dedicated help for the b key, to quickly return to the previous screen.
  • Bug Fixes

    • Improved UI consistency by switching headers, borders, selected-row states, and error/loading spinners to use the active theme styling across the app.
  • Documentation

    • Added a small formatting whitespace update to the README.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@digitalghost-dev, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 12 minutes and 7 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cdb7c68c-7897-445f-b4ce-913e6ce68bc5

📥 Commits

Reviewing files that changed from the base of the PR and between b9f611e and 1282678.

📒 Files selected for processing (5)
  • cmd/card/cardlist.go
  • cmd/comp/shell/frame.go
  • cmd/types/types.go
  • styling/styling.go
  • styling/styling_test.go
📝 Walkthrough

Walkthrough

The PR replaces yellow theme styling with shared theme color/style values across UI components, and adds picker back-navigation handling that propagates a back result through the shell loop and tests.

Changes

Theme Styling Migration

Layer / File(s) Summary
Theme globals and application
styling/styling.go, styling/styling_test.go
ThemeColor and Theme replace the old yellow globals, ApplyTheme writes the new values, and the theme-switch test now tracks ThemeColor.
Shell styles and frame rendering
cmd/comp/shell/styles.go, cmd/comp/shell/frame.go, cmd/comp/shell/dashboard.go, cmd/comp/shell/frame_test.go
Styles drops HighlightColor, shell frame and table styles use ThemeColor, the Overview tab renders with ThemeColor, and the constructor test now checks for a non-nil styles value.
Panel and table accent colors
cmd/berry/berry.go, cmd/berry/berry_test.go, cmd/card/cardlist.go, cmd/card/imageviewer.go, cmd/types/types.go, cmd/types/types_test.go, flags/pokemon_flagset.go, setup/setup.go
Focused borders and selected backgrounds in berry, card, type, flag, and setup views switch from yellow to ThemeColor.
Rendered labels and spinners
cmd/card/cardlist.go, cmd/card/imageviewer.go, cmd/card/setslist.go, cmd/comp/champions/tab_components.go, cmd/speed/speed.go, setup/setup.go
Selected headings, spinner styles, and speed output rendering now use styling.Theme.

Shell Back Navigation

Layer / File(s) Summary
Picker back action
cmd/comp/shell/picker.go
pickerModel records back requests, quits on b, exposes the back binding in help output, and uses the theme spinner style.
Loop return value propagation
cmd/comp/shell/run.go, cmd/comp/shell/run_test.go
Run and loop return a back result alongside errors, and the loop tests assert the new back state across selection, dashboard, and error paths.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

  • digitalghost-dev/poke-cli#211: Also changes theme-related styling globals and cmd/speed/speed.go rendering in the same yellow-to-theme migration.

Poem

I hopped through themes with a tiny grin,
A back key b let the loop begin.
✨ Yellow’s gone; the theme shines bright,
With spinner swirls and panels light.
My carrot UI hums just right.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 13.79% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is only a version number and does not describe the changeset. Replace it with a concise summary of the main change, such as the theme-color styling update.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2.0.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@digitalghost-dev digitalghost-dev moved this to Pull Request in poke-cli Jun 24, 2026
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.36508% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/comp/shell/picker.go 50.00% 3 Missing and 2 partials ⚠️
cmd/berry/berry.go 50.00% 2 Missing ⚠️
setup/setup.go 0.00% 2 Missing ⚠️
styling/styling.go 80.00% 1 Missing and 1 partial ⚠️
cmd/card/imageviewer.go 50.00% 1 Missing ⚠️
cmd/comp/shell/run.go 83.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
cmd/card/cardlist.go 66.83% <100.00%> (ø)
cmd/card/setslist.go 64.00% <100.00%> (ø)
cmd/comp/champions/tab_components.go 98.60% <100.00%> (ø)
cmd/comp/shell/dashboard.go 81.00% <100.00%> (ø)
cmd/comp/shell/frame.go 100.00% <100.00%> (ø)
cmd/comp/shell/styles.go 100.00% <100.00%> (ø)
cmd/speed/speed.go 40.14% <100.00%> (ø)
cmd/types/types.go 81.48% <100.00%> (ø)
flags/pokemon_flagset.go 72.84% <100.00%> (ø)
cmd/card/imageviewer.go 70.00% <50.00%> (ø)
... and 5 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cmd/comp/shell/frame.go`:
- Around line 71-73: The selected-row styling in frame.go is hardcoding the
foreground to black while using the active theme color as the background, which
can break contrast with darker themes. Update the selection styling in the
relevant frame rendering path so the foreground color is chosen dynamically from
the theme brightness instead of always using lipgloss.Color("`#000`"), keeping the
selected row readable across theme colors.

In `@cmd/comp/shell/run_test.go`:
- Around line 89-90: The test in run_test should use require.NoError instead of
assert.NoError for the loop(testSpec(), noopConn, runPicker, runDashboard) setup
check so the test stops immediately on unexpected initialization failure. Update
the assertion in this test to the require variant and keep the same error check
around the back, err assignment to satisfy testifylint’s require-error rule.

In `@styling/styling.go`:
- Around line 26-32: Initialize the global theme values in styling.go so they
are not zero-valued before ApplyTheme runs; set ThemeColor and Theme to the
default palette used by downstream views. Update the styling package’s global
defaults alongside Green, Red, and Gray so any code reading ThemeColor or Theme
directly still gets the intended accent styling before theme application, and
keep ApplyTheme responsible for overriding those defaults when a custom theme is
applied.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: daecccff-3a3a-4a3f-b787-819fc2d1e821

📥 Commits

Reviewing files that changed from the base of the PR and between 968f103 and adf1595.

📒 Files selected for processing (21)
  • README.md
  • cmd/berry/berry.go
  • cmd/berry/berry_test.go
  • cmd/card/cardlist.go
  • cmd/card/imageviewer.go
  • cmd/card/setslist.go
  • cmd/comp/champions/tab_components.go
  • cmd/comp/shell/dashboard.go
  • cmd/comp/shell/frame.go
  • cmd/comp/shell/frame_test.go
  • cmd/comp/shell/picker.go
  • cmd/comp/shell/run.go
  • cmd/comp/shell/run_test.go
  • cmd/comp/shell/styles.go
  • cmd/speed/speed.go
  • cmd/types/types.go
  • cmd/types/types_test.go
  • flags/pokemon_flagset.go
  • setup/setup.go
  • styling/styling.go
  • styling/styling_test.go
💤 Files with no reviewable changes (1)
  • cmd/comp/shell/frame_test.go

Comment thread cmd/comp/shell/frame.go
Comment thread cmd/comp/shell/run_test.go Outdated
Comment thread styling/styling.go
@digitalghost-dev digitalghost-dev linked an issue Jun 24, 2026 that may be closed by this pull request
@digitalghost-dev digitalghost-dev merged commit ddfb4ae into main Jun 24, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Pull Request to Completed in poke-cli Jun 24, 2026
@digitalghost-dev digitalghost-dev deleted the 2.0.1 branch June 24, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

Selected-row text unreadable on non-yellow themes Update YellowColor to ThemeColor to be more specific Hitting b does not return to main comp menu

1 participant