-
Notifications
You must be signed in to change notification settings - Fork 35
Add ARM Support #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM Support #1229
Changes from all commits
98725c5
8696799
5913387
3470deb
cf097a2
17fabf8
87702f4
f6e6794
3318e91
9c4ef0f
37f05dc
d4f53ca
bf457f1
ba7be91
45dfc78
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,7 +52,8 @@ dependencies = [ | |
| "colorlog==6.9.0", | ||
| # Core Msgs | ||
| "opencv-python", | ||
| "open3d", | ||
| "open3d-unofficial-arm; platform_system == 'Linux' and platform_machine == 'aarch64'", | ||
| "open3d>=0.18.0; platform_system != 'Linux' or platform_machine != 'aarch64'", | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the ONLY change that should be in this PR, everything else is to pass CI |
||
| # CLI | ||
Kaweees marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "pydantic-settings>=2.11.0,<3", | ||
| "textual==3.7.1", | ||
|
|
@@ -171,7 +172,7 @@ unitree = [ | |
|
|
||
| manipulation = [ | ||
| # Planning (Drake) | ||
| "drake>=1.40.0", | ||
| "drake>=1.40.0; platform_machine != 'aarch64'", | ||
|
|
||
| # Hardware SDKs | ||
| "piper-sdk", | ||
|
|
@@ -195,13 +196,13 @@ cpu = [ | |
| ] | ||
|
|
||
| cuda = [ | ||
| "cupy-cuda12x==13.6.0", | ||
| "nvidia-nvimgcodec-cu12[all]", | ||
| "onnxruntime-gpu>=1.17.1", # Only versions supporting both cuda11 and cuda12 | ||
| "cupy-cuda12x==13.6.0; platform_machine == 'x86_64'", | ||
| "nvidia-nvimgcodec-cu12[all]; platform_machine == 'x86_64'", | ||
| "onnxruntime-gpu>=1.17.1; platform_machine == 'x86_64'", # Only versions supporting both cuda11 and cuda12 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some features may not work given we have to "mute" a lot of packages given they lack ARM support. We might have to build ARM wheels for all of these
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah I was debating these. Right now cuda on arm doesn't work because of the jetpack issues anyways (like on the G1). Its a medium/low-priority to get cuda on Arm rn compared to just getting arm support. So I think its fine as-is |
||
| "ctransformers[cuda]==0.2.27", | ||
| "mmengine>=0.10.3", | ||
| "mmcv>=2.1.0", | ||
| "xformers>=0.0.20", | ||
| "xformers>=0.0.20; platform_machine == 'x86_64'", | ||
| ] | ||
|
|
||
| dev = [ | ||
|
|
@@ -297,7 +298,8 @@ docker = [ | |
| "sortedcontainers", | ||
| "PyTurboJPEG", | ||
| "rerun-sdk", | ||
| "open3d" | ||
| "open3d-unofficial-arm; platform_system == 'Linux' and platform_machine == 'aarch64'", | ||
| "open3d>=0.18.0; platform_system != 'Linux' or platform_machine != 'aarch64'", | ||
| ] | ||
|
|
||
| base = [ | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change was on dev at some point idk how it got removed but not having it causes problems because
xcbuildis a macos tool