feat: Add AV1 video codec support #258
Merged
+57,407
−534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skidder
force-pushed
the
feature/av1-support
branch
2 times, most recently
from
43388a3 to
e25a6ca
Compare
This commit adds support for AV1 video decoding in lilliput, following the same pattern as HEVC support with build flag gating. Changes: - Add AV1 decoder enablement behind build flag (av1Enabled) - Update FFmpeg build scripts to include --enable-decoder=av1 and --enable-libaom - Add codec gating logic to reject AV1 when disabled (default) - Add basic tests for AV1 support and decoder creation - Include test AV1 video file for validation Usage: Enable AV1 support: go build -ldflags="-X=github.com/discord/lilliput.av1Enabled=true" Features: - AV1 video detection in containers (MP4, WebM, etc.) - First-frame extraction from AV1 videos - Same security model as HEVC (disabled by default)
skidder
force-pushed
the
feature/av1-support
branch
from
06616f5 to
314f0d3
Compare
salarkhan
reviewed
Jun 23, 2025
salarkhan
reviewed
Jun 23, 2025
salarkhan
reviewed
Jun 23, 2025
| static int avcodec_decoder_copy_frame(const avcodec_decoder d, opencv_mat mat, AVFrame* frame) | ||
| { | ||
| if (!d || !d->codec || !d->codec->codec || !mat || !frame) { | ||
| return -1; |
Contributor
There was a problem hiding this comment.
at some point (not in this pr) we should probably move to more modern c++ features like std::optional/std::expected instead of spitting out -1 for errs no?
Contributor
Author
There was a problem hiding this comment.
For sure - in the meantime I think we should stick with numeric return codes, as C++ exceptions have bitten us recently.
salarkhan
approved these changes
Jun 23, 2025
Contributor
salarkhan
left a comment
salarkhan
left a comment
There was a problem hiding this comment.
ignored all the .h or .a files, but the rest lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces AV1 video codec support to lilliput, adding the dav1d AV1 decoding library to FFmpeg for improved AV1 and AVIF processing performance. It also ensures comprehensive dependency header coverage and licensing compliance across all platforms.
Key Changes
Core Features
Implementation Details
Build System Updates:
--enable-decoder=av1,--enable-libdav1d)Dependency Infrastructure:
third-party-licenses/Code Changes:
av1Enabledcontrols AV1 support (disabled by default)avcodec_decoder_create()to accept AV1 enablement parameterTesting:
avcodec_test.gotestdata/av1-mp4.mp4)Usage
Enable AV1 support:
go build -ldflags="-X=github.com/discord/lilliput.av1Enabled=true"Run AV1 tests:
Dependencies Added
Security Considerations
References
This implementation provides a foundation for efficient AV1 video processing while maintaining lilliput's security-first approach to codec support and ensuring complete dependency management across all supported platforms.