-
Notifications
You must be signed in to change notification settings - Fork 19
refactor: Common data table model #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…nt storage approaches.
…ies of the target class.
…ght be storing base (pure virtual) classes.
|
@rprospero As mentioned earlier some quite significant evolution has happened here. There's a lot going on, but the summary is captured below. Thoughts, comments, and ideas for alternative approaches very welcome.
|
rprospero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I like this setup and it feels clean. I've made some comments about some places where I might have handled the types differently, but there may be corner cases that I haven't considered.
Co-authored-by: Adam Washington <[email protected]>
Co-authored-by: Adam Washington <[email protected]>
…returning a pair..
Implements a standard interface between
QAbstractTableModeland any of our custom classes requiring such a display in the UI.TODO
insertRows()removeRows()ExpressionVariableVectorKeywordneeds to update related nodes when a parameter is removed. or added, or renamed.FilteringStandard Qt proxy model when requiredConversions
Tables with Filter Proxies
AtomTypeModelBraggReflectionModelSitesModelSpeciesSiteModelTables
DataManagerSimulationModelMasterTermModel(inherited)ModuleModelRangeVectorModelSpeciesAtomModelSpeciesBondModelSpeciesAngleModelSpeciesTorsionModelSpeciesImproperModelWeightedModuleModelXMLBondModelXMLAngleModelXMLTorsionModelXMLImproperModelQAbstractListModelsConfigurationModelEnumOptionsModelExternalPotentialModelSpeciesModelCloses #1902.