DateTimeFieldAdapters as a preparation for removing Time. #647#652
Open
lemonboston wants to merge 4 commits into
Open
DateTimeFieldAdapters as a preparation for removing Time. #647#652lemonboston wants to merge 4 commits into
lemonboston wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds two
FieldAdapters:TimestampDateTimeFieldAdapter- for fields that only use a timestampCombinedDateTimeFieldAdapter- for combined date-time fieldsThey are not wired in yet here.
Many additional types, classes have been added for the implementation, to support code re-use and to move towards having every date-time interpretation code/logic defined only at one place in the code base.
There is already a
DateTimeFieldAdapterfor the other type ofFieldAdapter(org.dmfs.provider.tasks.model.adapters.FieldAdapter) in the codebase, the next step could be to update that with the classes used here, while also reviewing that it interprets date-times the same way.After that we could wire in the new
FieldAdapters, which will probably mean the need to removeTimeat the same time from almost everywhere.