-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add logging while waiting for services #13463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ndeloof
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need a new --log flag, which would only apply in combination with --wait. We can just attach to containers when --wait is set; users who prefer to keep it quiet can redirect output, rely on start --wait or maybe use --attach=.
Doing so you don't need a new flag not new AP attributes, the challenge becomes getting composeService.up to stop early, after container all get healthy (which is managed in start
okay noted, will work on it. |
Signed-off-by: Mark Jagyo <[email protected]>
Signed-off-by: Mark Jagyo <[email protected]>
79e9a75 to
bd9a238
Compare
Signed-off-by: Mark Jagyo <[email protected]>
bd9a238 to
d96fb10
Compare
|
@ndeloof I think its working now on |
Signed-off-by: Mark Jagyo <[email protected]>
Signed-off-by: Mark Jagyo <[email protected]>
Introduce a --log flag for docker compose wait and docker compose up --wait to emit progress output while services are starting.