Skip to content

re-implement compose logic #13641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndeloof wants to merge 9 commits into
base: main
Choose a base branch
from
Open

re-implement compose logic #13641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1e0ab9b
re-implement compose logic
ndeloof Mar 15, 2026
2b9bb31
more tests
ndeloof Mar 19, 2026
11738ab
more tests
ndeloof Mar 19, 2026
d378225
fix some design issues
ndeloof Apr 13, 2026
779ffb4
fix corner cases
ndeloof Apr 13, 2026
c02d523
restore high-level events
ndeloof Apr 14, 2026
adf39f8
Élimination du ContainerInspect superflu
ndeloof Apr 14, 2026
487c1cd
Limite le parallélisme
ndeloof Apr 14, 2026
2e7acd0
pre-load e2e test images
ndeloof Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,26 @@ jobs:
- name: Build example provider
run: make example-provider

- name: Pre-pull e2e test images
run: |
# Pull images used by e2e fixtures in parallel to avoid test
# timeouts caused by slow downloads on cold CI runners.
images=(
"alpine"
"nginx"
"nginx:alpine"
"busybox"
"bash"
"hello-world"
"mariadb"
"fluent/fluent-bit:3.1.7-debug"
"alpine/curl"
)
for img in "${images[@]}"; do
docker pull "$img" &
done
wait

- name: Build
uses: docker/bake-action@82490499d2e5613fcead7e128237ef0b0ea210f7 # v7
with:
Expand Down
3 changes: 2 additions & 1 deletion cmd/compose/compose.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import (
"syscall"

"github.com/compose-spec/compose-go/v2/cli"
"github.com/compose-spec/compose-go/v2/consts"
"github.com/compose-spec/compose-go/v2/dotenv"
"github.com/compose-spec/compose-go/v2/loader"
composepaths "github.com/compose-spec/compose-go/v2/paths"
Expand Down Expand Up @@ -221,7 +222,7 @@ func makeJSONError(err error) error {
}

func (o *ProjectOptions) addProjectFlags(f *pflag.FlagSet) {
f.StringArrayVar(&o.Profiles, "profile", []string{}, "Specify a profile to enable")
f.StringArrayVar(&o.Profiles, "profile", defaultStringArrayVar(consts.ComposeProfiles), "Specify a profile to enable")
f.StringVarP(&o.ProjectName, "project-name", "p", "", "Project name")
f.StringArrayVarP(&o.ConfigPaths, "file", "f", []string{}, "Compose configuration files")
f.StringArrayVar(&o.insecureRegistries, "insecure-registry", []string{}, "Use insecure registry to pull Compose OCI artifacts. Doesn't apply to images")
Expand Down
Loading