Skip to content

fix: drop malformed bounding boxes #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
b-hahn wants to merge 2 commits into
base: main
Choose a base branch
from
+115 −83
Draft

fix: drop malformed bounding boxes #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd586ed
Ignore zero-height and zero-width bounding boxes.
b-hahn Dec 10, 2025
5e71eec
Return no element if empty bounding box is extracted.
b-hahn Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions docling_core/types/doc/document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5351,6 +5351,10 @@ def extract_bounding_box(text_chunk: str) -> Optional[BoundingBox]:
coords = coords[:4]
if len(coords) == 4:
l, t, r, b = map(float, coords)
eps = 1 / 500
# Ignore bounding boxes with width or height of <1e-3, including cases where l>r or t>b.
if r - l < eps or b - t < eps:
return None
return BoundingBox(l=l / 500, t=t / 500, r=r / 500, b=b / 500)
return None

Expand All @@ -5366,12 +5370,13 @@ def extract_caption(
if caption is not None:
caption_content = caption.group(1)
bbox = extract_bounding_box(caption_content)
caption_text = extract_inner_text(caption_content)
caption_item = doc.add_text(
label=DocItemLabel.CAPTION,
text=caption_text,
parent=None,
)
if bbox is not None:
Copy link
Member

@cau-git cau-git Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this condition so captions are created also when the bbox is not present, as before.

caption_text = extract_inner_text(caption_content)
caption_item = doc.add_text(
label=DocItemLabel.CAPTION,
text=caption_text,
parent=None,
)
else:
caption_item = None
bbox = None
Expand Down Expand Up @@ -5634,17 +5639,20 @@ def _add_text(
common_bbox = extract_bounding_box(content)
for item_match in pattern.finditer(content):
item_tag = item_match.group("tag")
_add_text(
full_chunk=item_match.group(0),
bbox=common_bbox,
pg_width=pg_width,
pg_height=pg_height,
page_no=page_no,
tag_name=item_tag,
doc_label=tag_to_doclabel.get(item_tag, DocItemLabel.TEXT),
doc=doc,
parent=inline_group,
)
if common_bbox is not None:
Copy link
Member

@cau-git cau-git Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this condition so that _add_text is called also with a None bounding box, as before.

_add_text(
full_chunk=item_match.group(0),
bbox=common_bbox,
pg_width=pg_width,
pg_height=pg_height,
page_no=page_no,
tag_name=item_tag,
doc_label=tag_to_doclabel.get(
item_tag, DocItemLabel.TEXT
),
doc=doc,
parent=inline_group,
)

elif tag_name in [DocItemLabel.PICTURE, DocItemLabel.CHART]:
caption, caption_bbox = extract_caption(full_chunk)
Expand Down
36 changes: 3 additions & 33 deletions test/data/doc/2408.09869v3_enriched.dt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4960,22 +4960,7 @@
"children": [],
"content_layer": "body",
"label": "text",
"prov": [
{
"page_no": 9,
"bbox": {
"l": 670.7520000000001,
"t": 887.0400000000001,
"r": 670.7520000000001,
"b": 899.7119999999999,
"coord_origin": "TOPLEFT"
},
"charspan": [
0,
1
]
}
],
"prov": [],
"orig": ",",
"text": ","
},
Expand Down Expand Up @@ -5041,22 +5026,7 @@
"children": [],
"content_layer": "body",
"label": "text",
"prov": [
{
"page_no": 9,
"bbox": {
"l": 692.784,
"t": 899.7119999999999,
"r": 692.784,
"b": 912.3839999999999,
"coord_origin": "TOPLEFT"
},
"charspan": [
0,
1
]
}
],
"prov": [],
"orig": ".",
"text": "."
},
Expand Down Expand Up @@ -15297,4 +15267,4 @@
"page_no": 9
}
}
}
}
36 changes: 3 additions & 33 deletions test/data/doc/2408.09869v3_enriched.out.dt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4960,22 +4960,7 @@
"children": [],
"content_layer": "body",
"label": "text",
"prov": [
{
"page_no": 9,
"bbox": {
"l": 670.7520000000001,
"t": 887.0400000000001,
"r": 670.7520000000001,
"b": 899.7119999999999,
"coord_origin": "TOPLEFT"
},
"charspan": [
0,
1
]
}
],
"prov": [],
"orig": ",",
"text": ","
},
Expand Down Expand Up @@ -5041,22 +5026,7 @@
"children": [],
"content_layer": "body",
"label": "text",
"prov": [
{
"page_no": 9,
"bbox": {
"l": 692.784,
"t": 899.7119999999999,
"r": 692.784,
"b": 912.3839999999999,
"coord_origin": "TOPLEFT"
},
"charspan": [
0,
1
]
}
],
"prov": [],
"orig": ".",
"text": "."
},
Expand Down Expand Up @@ -16044,4 +16014,4 @@
"page_no": 9
}
}
}
}
4 changes: 4 additions & 0 deletions test/data/doc/defect_bbox_page.dt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Assistant: <doctag>
<text><loc_68><loc_447><loc_445><loc_447>This is valid text with a zero-height bounding box.</text>
<text><loc_68><loc_447><loc_32><loc_499>This is valid text with a negative-width bounding box.</text>
</doctag><end_of_utterance>
66 changes: 66 additions & 0 deletions test/data/doc/defect_bbox_page.dt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
{
"body": {
"children": [
{
"$ref": "#/texts/0"
},
{
"$ref": "#/texts/1"
}
],
"content_layer": "body",
"label": "unspecified",
"name": "_root_",
"self_ref": "#/body"
},
"form_items": [],
"furniture": {
"children": [],
"content_layer": "furniture",
"label": "unspecified",
"name": "_root_",
"self_ref": "#/furniture"
},
"groups": [],
"key_value_items": [],
"name": "Document",
"pages": {
"1": {
"page_no": 1,
"size": {
"height": 1.0,
"width": 1.0
}
}
},
"pictures": [],
"schema_name": "DoclingDocument",
"tables": [],
"texts": [
{
"children": [],
"content_layer": "body",
"label": "text",
"orig": "This is valid text with a zero-height bounding box.",
"parent": {
"$ref": "#/body"
},
"prov": [],
"self_ref": "#/texts/0",
"text": "This is valid text with a zero-height bounding box."
},
{
"children": [],
"content_layer": "body",
"label": "text",
"orig": "This is valid text with a negative-width bounding box.",
"parent": {
"$ref": "#/body"
},
"prov": [],
"self_ref": "#/texts/1",
"text": "This is valid text with a negative-width bounding box."
}
],
"version": "1.8.0"
}
14 changes: 14 additions & 0 deletions test/test_doctags_load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,3 +168,17 @@ def test_doctags_inline():
exp_file=exp,
actual=deser_doc.export_to_dict(),
)


def test_doctags_handle_defect_bbox():

doctags_doc = DocTagsDocument.from_doctags_and_image_pairs(
[Path("test/data/doc/defect_bbox_page.dt")], None
)

doc = DoclingDocument.load_from_doctags(doctags_doc)
exp = "test/data/doc/defect_bbox_page.dt.json"
verify(
exp_file=exp,
actual=doc.export_to_dict(),
)
Loading