fix: require Node 22.12+ to match wrangler and Vite 8 - #257
Merged
Conversation
wrangler 4.125 requires Node >=22, and Vite 8 excludes 22.0-22.11. Tighten engines.node so Node 20 installs fail early. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to Copilot review on #256.
wrangler@4.125.0requires Node>=22.0.0, and Vite 8 requires>=22.12.0on the Node 22 line. The previousengines.nodestill allowed^20.19.0, so tighten it to>=22.12.0.CI already uses Node 22.
Test plan
engines.nodeis>=22.12.0Made with Cursor