Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR transitions the project from a dual CommonJS/ESM build setup to ESM-only, representing a breaking change that simplifies the build configuration and modernizes the package structure.
- Removes dual build system and related TypeScript configurations
- Updates package.json to specify "type": "module" and consolidates entry points
- Replaces CommonJS module detection pattern with ESM equivalent using import.meta.url
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.test.json | Removed test-specific TypeScript configuration |
| tsconfig.mjs.json | Removed ESM-specific TypeScript configuration |
| tsconfig.cjs.json | Removed CommonJS-specific TypeScript configuration |
| src/index.ts | Updated module detection from require.main to import.meta.url pattern |
| package.json | Set module type to ESM, updated build scripts, and replaced ts-node with tsx |
| fixup.sh | Removed build script that created dual package.json files |
| .eslintrc | Minor formatting cleanup and removed mocha environment |
| .cfignore | Removed Cloud Foundry ignore file |
| .babelrc | Removed Babel configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dopry
force-pushed
the
chore/esm
branch
2 times, most recently
from
September 20, 2025 03:58
3533cd3 to
8b040f6
Compare
dopry
force-pushed
the
chore/esm
branch
8 times, most recently
from
June 26, 2026 19:59
d27f64a to
f60fe95
Compare
Comment on lines
+84
to
87
| const entry = process.argv[1] ? realpathSync(process.argv[1]) : ""; | ||
| if (entry && realpathSync(import.meta.filename) === entry) { | ||
| main(); | ||
| } |
Comment on lines
1
to
+2
| import { gt } from "semver"; | ||
| import { PecansRelease } from "../models"; | ||
| import { PecansRelease } from "../models/index.js"; |
| @@ -1,4 +1,4 @@ | |||
| import { PecansRelease } from "../models"; | |||
| import { PecansRelease } from "../models/index.js"; | |||
Comment on lines
11
to
14
| // TypeScript configuration | ||
| typecheck: { | ||
| tsconfig: "./tsconfig.test.json", | ||
| tsconfig: "./tsconfig.json", | ||
| }, |
Comment on lines
1
to
3
| import Debug from "debug"; | ||
| import { NextFunction, Request, Response, Router } from "express"; | ||
| import { type NextFunction, type Request, type Response, Router } from "express"; | ||
| import useragent from "express-useragent"; |
| import { generateRELEASES, parseRELEASES } from "./utils/win-releases.js"; | ||
| import { type VersionFilterOpts, Versions } from "./versions.js"; | ||
|
|
||
| const logger = Debug("pecans"); |
!BREAKING CHANGE:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!BREAKING CHANGE: