Conversation
…+ added DEFAULT variantId logic in PageResourceHelper in case of null/empty values
5 tasks
ihoffmann-dot
requested review from
dario-daza,
fabrizzio-dotCMS and
nollymar
nollymar
approved these changes
Feb 20, 2026
dario-daza
approved these changes
Feb 20, 2026
fabrizzio-dotCMS
approved these changes
Feb 20, 2026
oidacra
pushed a commit
that referenced
this pull request
Feb 20, 2026
…ll + added DEFAULT variantId logic in PageResourceHelper (#34696) ## Summary Moved Multitree validation before copyContentlet call + added DEFAULT variantId logic in PageResourceHelper in case of null/empty values. ## Changes - Changed the validation order in PageResourceHelper.copyContentlet() method. Now we validate the existence of the Multitree before actually copying the Contentlet. - Added a default value for variantId in case the value from the request is null or empty. - Added integration tests. ## Motivation The issue related to this PR shows that we return a 404 when attempting to copy a contentlet and the variantId in the request is empty. To address this, we added logic to set a default value when the variantId is null or empty. Additionally, while investigating this issue, we uncovered another problem. The contentlet was being copied before doing the required validations for the Multitree. So when the Multitree call returned null, the response was still a 404, but the contentlet had already been copied, and the rollback was not being done. This means the bug was not limited to the empty variantId scenario. Any case where the Multitree was null could trigger the same unintended behavior. ## Related Issue Fixes: [BUG: PUT /api/v1/page/copyContent returns 404 but successfully copies content when variantId is empty string #34473](#34473)
dsolistorres
pushed a commit
that referenced
this pull request
Feb 20, 2026
…ll + added DEFAULT variantId logic in PageResourceHelper (#34696) ## Summary Moved Multitree validation before copyContentlet call + added DEFAULT variantId logic in PageResourceHelper in case of null/empty values. ## Changes - Changed the validation order in PageResourceHelper.copyContentlet() method. Now we validate the existence of the Multitree before actually copying the Contentlet. - Added a default value for variantId in case the value from the request is null or empty. - Added integration tests. ## Motivation The issue related to this PR shows that we return a 404 when attempting to copy a contentlet and the variantId in the request is empty. To address this, we added logic to set a default value when the variantId is null or empty. Additionally, while investigating this issue, we uncovered another problem. The contentlet was being copied before doing the required validations for the Multitree. So when the Multitree call returned null, the response was still a 404, but the contentlet had already been copied, and the rollback was not being done. This means the bug was not limited to the empty variantId scenario. Any case where the Multitree was null could trigger the same unintended behavior. ## Related Issue Fixes: [BUG: PUT /api/v1/page/copyContent returns 404 but successfully copies content when variantId is empty string #34473](#34473)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moved Multitree validation before copyContentlet call + added DEFAULT variantId logic in PageResourceHelper in case of null/empty values.
Changes
Motivation
The issue related to this PR shows that we return a 404 when attempting to copy a contentlet and the variantId in the request is empty. To address this, we added logic to set a default value when the variantId is null or empty.
Additionally, while investigating this issue, we uncovered another problem. The contentlet was being copied before doing the required validations for the Multitree. So when the Multitree call returned null, the response was still a 404, but the contentlet had already been copied, and the rollback was not being done.
This means the bug was not limited to the empty variantId scenario. Any case where the Multitree was null could trigger the same unintended behavior.
Related Issue
Fixes: BUG: PUT /api/v1/page/copyContent returns 404 but successfully copies content when variantId is empty string #34473