feat: add grid block with two-column layout to block editor#34789
Open
fmontes wants to merge 3 commits intoissue-33882-primeng-updatefrom
Open
feat: add grid block with two-column layout to block editor#34789fmontes wants to merge 3 commits intoissue-33882-primeng-updatefrom
fmontes wants to merge 3 commits intoissue-33882-primeng-updatefrom
Conversation
Adds a new grid block node that provides a two-column layout where each column can contain independent sub-blocks. Uses pure TipTap node definitions (same pattern as tables) with CSS Grid for layout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. MPL-2.0
|
Remove all 25 SCSS files from the block editor and replace with plain CSS using CSS custom properties and literal values. All selectors are fully flattened (no CSS nesting) for compatibility with Angular view encapsulation. ProseMirror DOM styles are inlined in the main component CSS with ::ng-deep selectors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gridBlockTipTap node with two-column layout, following the same pure-node pattern as tables (no Angular components needed)gridColumn) supports independent nested blocks (paragraphs, headings, images, lists, etc.)Test plan
/and search for "Grid" — should see "Grid (2 columns)"🤖 Generated with Claude Code