Fix flaky SequentialAccess test with dynamic expected value#4224
Open
ShreyaLaxminarayan wants to merge 1 commit intodotnet:mainfrom
Open
Fix flaky SequentialAccess test with dynamic expected value#4224ShreyaLaxminarayan wants to merge 1 commit intodotnet:mainfrom
ShreyaLaxminarayan wants to merge 1 commit intodotnet:mainfrom
Conversation
Description: The SequentialAccess test in DataStreamTest.cs was asserting a hardcoded byte count (536198) for the result of SELECT * FROM orders FOR XML AUTO. This value was tied to a specific state of the Northwind database and would fail whenever the Orders table content differed across test environments or servers. Fix: Replace the hardcoded expected value with a dynamically computed baseline using a direct SQL query, independent of the C# APIs under test. -All 4 hardcoded assertions replaced with expectedTotal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The SequentialAccess test in DataStreamTest.cs was asserting a hardcoded byte count (536198) for the result of
SELECT * FROM orders FOR XML AUTO.This value was tied to a specific state of the Northwind database and would fail whenever the Orders table content differed across test environments or servers.
Fix:
Replace the hardcoded expected value with a dynamically computed baseline using a direct SQL query, independent of the C# APIs under test.
-All 4 hardcoded assertions replaced with expectedTotal