Revert "Fixes Problem Details casing bug (#59396)"#67011
Open
Youssef1313 wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
area-networking
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the prior change that applied JsonSerializerOptions.PropertyNamingPolicy to the traceId extension key in DefaultProblemDetailsWriter, restoring consistent traceId casing and aligning with how System.Text.Json treats JsonPropertyName and extension-data keys for ProblemDetails.
Changes:
- Always writes the trace identifier under the literal
"traceId"extension key (no naming policy conversion). - Removes the test that asserted
traceIdkey casing changes with differentJsonNamingPolicyvalues. - Minor adjustments to casing-related assertions in existing tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs | Reverts naming-policy-based traceId key generation; always uses "traceId". |
| src/Http/Http.Extensions/test/ProblemDetailsDefaultWriterTest.cs | Removes naming-policy casing theory; keeps/updates casing assertions for "traceId". |
Youssef1313
added
feature-problem-details
area-minimal
BrennanConroy
approved these changes
Jun 4, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #59876
Fixes #65543
Fixes #66603
This resolves the inconsistency of how the naming policy is applied and we let STJ do its thing. Note that the STJ behavior here looks intentional dotnet/runtime#31167. Given that this can't round trip correctly, and that the current behavior is already very inconsistent, I think it's better to revert to the original behavior.