Provide custom comparer support for in-memory QuickGrid sorting#67035
Open
VigneshwaranGovindharajan wants to merge 8 commits into
Open
Conversation
Contributor
|
Thanks for your PR, @VigneshwaranGovindharajan. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Author
Author
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide custom comparer support for in-memory QuickGrid sorting
Description
Adds support for custom comparisons in QuickGrid sorting by accepting an IComparer on GridSort and exposing comparer usage on PropertyColumn. This enables consumers to supply custom ordering (for example, sort strings by length, by vowel count, or integers by absolute value) when the data is materialized in memory.
Important: custom comparers are supported only when sorting is performed in-memory (LINQ-to-Objects). They cannot be translated to SQL/EF Core; trying to use comparers with remote IQueryable providers will not work and may cause runtime translation failures. Documentation and XML remarks call this out.
Changes:
Added comparer overloads on GridSort:
ByAscending(Expression<Func<T, U>> keySelector, IComparer comparer)
ByDescending(Expression<Func<T, U>> keySelector, IComparer comparer)
ThenAscending(Expression<Func<T, U>> keySelector, IComparer comparer)
ThenDescending(Expression<Func<T, U>> keySelector, IComparer comparer)
Each overload includes XML docs noting the in-memory-only restriction.
PropertyColumn<T, TProp>:
New [Parameter] public IComparer? Comparer { get; set; }
Column builds the column's sort specification using the comparer when provided.
Tracks comparer changes so the column updates SortBy when the comparer parameter changes.
Wiring:
GridItemsProviderRequest.ApplySorting(IQueryable) already calls SortByColumn?.SortBy?.Apply(...). The GridSort comparer overloads pass the comparer through to LINQ OrderBy/ThenBy overloads when the source is in-memory.
Fixes #45478