Dispose StreamReader reading from disk in XmlDocReader#2441
Open
omajid wants to merge 1 commit intodotnet:mainfrom
Open
Dispose StreamReader reading from disk in XmlDocReader#2441omajid wants to merge 1 commit intodotnet:mainfrom
omajid wants to merge 1 commit intodotnet:mainfrom
Conversation
We create a `StreamReader` via `File.OpenText`, but never `Dispose()` it. Wrap it in a `using` statement to automatically `Dispose()` it when `TryLoad(TextReader, ...)` is done using it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We create a
StreamReaderviaFile.OpenText, but neverDispose()it. Wrap it in ausingstatement to automaticallyDispose()it whenTryLoad(TextReader, ...)is done using it.