[tools/msbuild] Add InlineDlfcnMethodsStep as an opt-in custom linker step by rolfbjarne · Pull Request #24888 · dotnet/macios

rolfbjarne · 2026-03-12T12:31:23Z

Add a new custom linker step that replaces runtime Dlfcn.dlsym calls with
direct native symbol lookups via P/Invokes to __Internal. This improves
startup performance and app size, and ensures the native linker can see symbol
references that would otherwise only be resolved at runtime.

Two modes are supported, controlled by the InlineDlfcnMethods MSBuild
property:

strict: inlines all calls to ObjCRuntime.Dlfcn APIs.
compatibility: only inlines calls that reference symbols from [Field]
attributes.

Post-trimming MSBuild targets ensure native code is only generated for symbols
that survive trimming (ILTrim or NativeAOT):

_CollectPostILTrimInformation: scans trimmed assemblies for surviving
inlined dlfcn P/Invokes, with per-assembly caching for incremental builds.
_CollectPostNativeAOTTrimInformation: reads unresolved symbols from the
NativeAOT object file or static library and filters for inlined dlfcn symbols.
_PostTrimmingProcessing: generates native C code for surviving symbols and
adds it to the native link inputs.

Extends MachO.cs with LC_SYMTAB parsing to read unresolved symbols from both
Mach-O object files and static libraries.

Contributes towards #17693.

Copilot

Pull request overview

Adds an opt-in build+linker pipeline to inline ObjCRuntime.Dlfcn symbol lookups into direct __Internal P/Invokes, with post-trimming symbol discovery (ILTrim + NativeAOT) and native C code generation to keep only surviving symbol references.

Changes:

Introduces InlineDlfcnMethodsStep + GenerateInlinedDlfcnNativeCodeStep and corresponding InlineDlfcnMethods MSBuild property wiring.
Adds post-trimming MSBuild tasks/targets to detect surviving inlined symbols (ILTrim scanning + NativeAOT unresolved-symbol parsing) and generate/compile native glue code.
Extends Mach-O parsing to read unresolved symbols and adds/adjusts tests and test variations for the new modes.

Reviewed changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tools/mtouch/Errors.resx	Adds new MX2254–MX2257 warning strings for the inlining step.
tools/mtouch/Errors.designer.cs	Regenerated resource accessors for new MX225x entries.
tools/linker/MonoTouch.Tuner/ProcessExportedFields.cs	Collects `[Field]` symbol names for compatibility mode.
tools/linker/MonoTouch.Tuner/ListExportedSymbols.cs	Skips adding required field symbols when dlfcn inlining is enabled.
tools/dotnet-linker/Steps/InlineDlfcnMethodsStep.cs	New custom linker step that rewrites Dlfcn calls into generated helpers + P/Invokes.
tools/dotnet-linker/Steps/GenerateInlinedDlfcnNativeCodeStep.cs	Emits a symbol list file for later post-trimming MSBuild steps.
tools/dotnet-linker/LinkerConfiguration.cs	Adds `InlineDlfcnMethods` configuration and symbol tracking collections.
tools/dotnet-linker/AppBundleRewriter.cs	Adds type/method references used by the new inlining step.
tools/common/MachO.cs	Adds LC_SYMTAB parsing and unresolved-symbol extraction for Mach-O/static libraries.
tests/xharness/Jenkins/TestVariationsFactory.cs	Adds new CI variations to exercise inline-dlfcn modes (incl. NativeAOT).
tests/monotouch-test/ObjCRuntime/DlfcnTest.cs	Adds tests for `[Field]`-backed constants and adjusts behavior under strict mode.
tests/monotouch-test/Foundation/AttributedStringTest.cs	Removes legacy field-absence test that would conflict with new behavior.
tests/monotouch-test/CoreFoundation/ProxyTest.cs	Removes legacy field-absence test that would conflict with new behavior.
tests/common/test-variations.csproj	Adds `inline-dlfcn-methods-compat` and `inline-dlfcn-methods-strict` test variations.
msbuild/Xamarin.MacDev.Tasks/Tasks/PostTrimmingProcessing.cs	Generates native C glue for surviving symbols and outputs compile/link items.
msbuild/Xamarin.MacDev.Tasks/Tasks/ComputeNativeAOTSurvivingNativeSymbols.cs	Filters NativeAOT unresolved symbols to determine surviving inlined-dlfcn symbols.
msbuild/Xamarin.MacDev.Tasks/Tasks/CompileNativeCode.cs	Ensures output directory exists before compiling native files.
msbuild/Xamarin.MacDev.Tasks/Tasks/CollectUnresolvedNativeSymbols.cs	New task to extract unresolved symbols from a NativeAOT static library.
msbuild/Xamarin.MacDev.Tasks/Tasks/CollectPostILTrimInformation.cs	New task to scan trimmed assemblies and cache surviving inlined-dlfcn P/Invokes.
dotnet/targets/Xamarin.Shared.Sdk.targets	Wires property defaults, custom linker steps, and post-trimming targets into the SDK.
docs/code/native-symbols.md	New doc explaining the native symbol pipeline and InlineDlfcnMethods modes.
docs/building-apps/build-properties.md	Documents the new `InlineDlfcnMethods` MSBuild property and defaults.
.github/copilot-instructions.md	Adds MSBuild guidance (DeviceSpecificIntermediateOutputPath) to repo copilot instructions.

Files not reviewed (1)

tools/mtouch/Errors.designer.cs: Language not supported

You can also share your feedback on Copilot code review. Take the survey.

Add a new custom linker step that replaces runtime `Dlfcn.dlsym` calls with direct native symbol lookups via P/Invokes to `__Internal`. This improves startup performance and app size, and ensures the native linker can see symbol references that would otherwise only be resolved at runtime. Two modes are supported, controlled by the `InlineDlfcnMethods` MSBuild property: * `strict`: inlines all calls to `ObjCRuntime.Dlfcn` APIs. * `compatibility`: only inlines calls that reference symbols from `[Field]` attributes. Post-trimming MSBuild targets ensure native code is only generated for symbols that survive trimming (ILTrim or NativeAOT): * `_CollectPostILTrimInformation`: scans trimmed assemblies for surviving inlined dlfcn P/Invokes, with per-assembly caching for incremental builds. * `_CollectPostNativeAOTTrimInformation`: reads unresolved symbols from the NativeAOT object file or static library and filters for inlined dlfcn symbols. * `_PostTrimmingProcessing`: generates native C code for surviving symbols and adds it to the native link inputs. Extends `MachO.cs` with LC_SYMTAB parsing to read unresolved symbols from both Mach-O object files and static libraries. Contributes towards #17693 (even though this adds a *new* custom trimmer step, it's a pre-marking step that's easy to move out of the linker later on, and it's a partial replacement for the ListExportedSymbols step, which can't be moved out of the trimmer).

rolfbjarne · 2026-04-30T10:08:31Z

/review

github-actions · 2026-04-30T10:09:37Z

✅ .NET for Apple Platforms PR Reviewer completed successfully!

github-actions

Code Review Summary

This PR adds a sophisticated optimization to inline Dlfcn calls at build time, replacing runtime dlsym lookups with direct P/Invokes to native symbols. The implementation is well-structured with comprehensive documentation and test coverage.

Issues Found

❌ 1 Critical Bug:

PostTrimmingProcessing.cs line 54: Wrong variable in switch statement (symbolMode instead of symbolType) causing incorrect symbol filtering logic.

⚠️ 2 Potential Issues:

Missing input validation in CollectPostILTrimInformation.cs and ComputeNativeAOTSurvivingNativeSymbols.cs for symbol name extraction that could throw exceptions.

💡 1 Optimization:

Unnecessary .Where (s => s.Length > 0) filter in PostTrimmingProcessing.cs.

Positive Highlights

✅ Excellent documentation in docs/code/native-symbols.md explaining the architecture
✅ Proper incremental build support with per-assembly caching
✅ Comprehensive test coverage including edge cases
✅ Well-structured MSBuild integration with proper Inputs/Outputs attributes
✅ Clean separation of concerns between IL transformation and post-trimming processing
✅ Proper nullable reference type usage throughout

Architecture Review

The two-phase approach (IL transformation during linking + post-trimming native code generation) is sound and handles both ILTrim and NativeAOT scenarios elegantly. The MachO.cs symbol table parsing implementation looks correct and properly handles both 32-bit and 64-bit Mach-O files.

The critical bug in PostTrimmingProcessing.cs must be fixed before merge, as it breaks the ReferenceNativeSymbol ignore functionality.

Generated by .NET for Apple Platforms PR Reviewer for issue #24888 · ● 1.1M

Copilot

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

tools/mtouch/Errors.designer.cs: Language not supported

- Fix switch(symbolMode) -> switch(symbolType) in PostTrimmingProcessing.cs - Fix instr.Previous -> ins.Previous in 3-arg Dlfcn pattern matcher - Fix MachO.cs ar padding: % 1 -> % 2 - Fix typo 'qas' -> 'was' in Frameworks.cs - Fix #endif comment to match #if BUNDLER - Replace null! with TaskItem default in CollectUnresolvedNativeSymbols - Add Substring length validation in CollectPostILTrimInformation and ComputeNativeAOTSurvivingNativeSymbols - Use dlsym(RTLD_DEFAULT, ...) instead of extern void* for generated C code, which works for both function and data symbols - Remove unnecessary .Where(s => s.Length > 0) filter - Add IsValidCIdentifier check to skip symbols with invalid chars Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2026-04-30T11:16:37Z

✅ [PR Build #703de17] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 703de174091393c6052615c3425e37d77361e37e [PR build]

vs-mobiletools-engineering-service2 · 2026-04-30T11:19:47Z

✅ [PR Build #703de17] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 703de174091393c6052615c3425e37d77361e37e [PR build]

vs-mobiletools-engineering-service2 · 2026-04-30T11:32:09Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 703de174091393c6052615c3425e37d77361e37e [PR build]

vs-mobiletools-engineering-service2 · 2026-04-30T11:44:09Z

✅ [CI Build #703de17] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 703de174091393c6052615c3425e37d77361e37e [PR build]

vs-mobiletools-engineering-service2 · 2026-04-30T15:23:40Z

🚀 [CI Build #703de17] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 162 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 14 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 14 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 703de174091393c6052615c3425e37d77361e37e [PR build]

rolfbjarne · 2026-04-30T16:43:41Z

/review

Copilot

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 6 comments.

Files not reviewed (1)

tools/mtouch/Errors.designer.cs: Language not supported

Copilot · 2026-04-30T16:52:41Z

+
+The valid options are:
+
+* `compatibility`: Inlines dlfcn method calls but only creates native references for symbols used in `[Field]` attributes. This is more conservative and avoids link errors for symbols that don't exist at build time.


The compatibility bullet says it “inlines dlfcn method calls but only creates native references for symbols used in [Field] attributes”, but the implementation in InlineDlfcnMethodsStep actually skips inlining entirely for symbols not coming from [Field] attributes (in compatibility mode). Please adjust this description to match the actual behavior (only [Field]-backed symbol usages are inlined in compatibility mode).

Suggested change

* `compatibility`: Inlines dlfcn method calls but only creates native references for symbols used in `[Field]` attributes. This is more conservative and avoids link errors for symbols that don't exist at build time.

* `compatibility`: Only inlines symbol usages backed by `[Field]` attributes. This is more conservative and avoids link errors for symbols that don't exist at build time.

Copilot · 2026-04-30T16:52:42Z

+		<PostTrimmingProcessing
+			Architecture="$(TargetArchitectures)"
+			OutputDirectory="$(DeviceSpecificIntermediateOutputPath)inlined-dlfcn"
+			ReferenceNativeSymbol="@(ReferenceNativeSymbol)"
+			SurvivingNativeSymbolsFiles="@(_SurvivingNativeSymbolsFile)"


Architecture="$(TargetArchitectures)" may be a comma-separated list (often with spaces, e.g. "ARM64, x86_64"), but PostTrimmingProcessing/CompileNativeCode expect a single Arch value per compilation. As-is this can result in invalid -arch arguments. Consider splitting $(TargetArchitectures) into per-arch items and invoking PostTrimmingProcessing per arch (or having the task emit one output item per arch).

Copilot · 2026-04-30T16:52:42Z

+		<ItemGroup>
+			<FileWrites Include="@(_PostTrimmingSourceFiles)" />
+			<_PostTrimmingSourceFiles>
+				<OutputFile>$(DeviceSpecificIntermediateOutputPath)posttrim-info-compiled/%(Filename).o</OutputFile>


OutputFile for the post-trimming generated source is set to a single %(Filename).o. If you compile the same inlined-dlfcn.c for multiple architectures, this will cause object-file collisions/overwrites. Ensure the output path is unique per architecture (for example include %(Arch) in the path/name) if multi-arch compilation is supported here.

Suggested change

<OutputFile>$(DeviceSpecificIntermediateOutputPath)posttrim-info-compiled/%(Filename).o</OutputFile>

<OutputFile>$(DeviceSpecificIntermediateOutputPath)posttrim-info-compiled/%(Arch)/%(Filename).o</OutputFile>

Copilot · 2026-04-30T16:52:42Z

+		for (var i = 0; i < name.Length; i++) {
+			var c = name [i];
+			if (c == '_' || char.IsLetterOrDigit (c))
+				continue;
+			return false;
+		}
+		return name.Length > 0;


IsValidCIdentifier allows digits in any position, including as the first character. Since the symbol name becomes part of generated native identifiers (and corresponding P/Invokes), a leading digit would produce invalid generated C identifiers. Update the validation to require the first character to be '_' or a letter, and only allow digits after the first character.

Suggested change

for (var i = 0; i < name.Length; i++) {

var c = name [i];

if (c == '_' || char.IsLetterOrDigit (c))

continue;

return false;

}

return name.Length > 0;

if (name.Length == 0)

return false;

var first = name [0];

if (first != '_' && !char.IsLetter (first))

return false;

for (var i = 1; i < name.Length; i++) {

var c = name [i];

if (c == '_' || char.IsLetterOrDigit (c))

continue;

return false;

}

return true;

Copilot · 2026-04-30T16:52:43Z

+			var item = new Microsoft.Build.Utilities.TaskItem (outputPath);
+			item.SetMetadata ("Arch", Architecture.ToLowerInvariant ());


Architecture is passed through to the generated item metadata Arch as Architecture.ToLowerInvariant(). $(TargetArchitectures) can contain multiple comma-separated architectures (often with spaces, e.g. "ARM64, x86_64"), which would result in clang being invoked with -arch "arm64, x86_64" (invalid) and/or missing per-arch compilation. This task should either (1) emit one NativeSourceFiles item per architecture (each with a single Arch value), or (2) validate that Architecture is a single architecture and fail with a clear error if not.

Suggested change

var item = new Microsoft.Build.Utilities.TaskItem (outputPath);

item.SetMetadata ("Arch", Architecture.ToLowerInvariant ());

var architectures = Architecture.Split (',').Select (v => v.Trim ()).Where (v => v.Length > 0).ToArray ();

if (architectures.Length != 1) {

Log.LogError ("The '{0}' property must contain exactly one architecture for post-trimming processing, but was '{1}'.", nameof (Architecture), Architecture);

return;

}

var item = new Microsoft.Build.Utilities.TaskItem (outputPath);

item.SetMetadata ("Arch", architectures [0].ToLowerInvariant ());

Copilot · 2026-04-30T16:52:43Z

+					if (Enum.TryParse<InlineDlfcnMethodsMode> (value, true, out var inlineDlfcnMode))
+						InlineDlfcnMethods = inlineDlfcnMode;
+					else if (string.Equals (value, "compatibility", StringComparison.OrdinalIgnoreCase))
+						InlineDlfcnMethods = InlineDlfcnMethodsMode.Compat;
+					else if (string.IsNullOrEmpty (value))
+						InlineDlfcnMethods = InlineDlfcnMethodsMode.Disabled;
+					else


InlineDlfcnMethods parsing uses Enum.TryParse, which will accept values like Disabled. However the MSBuild condition that wires in InlineDlfcnMethodsStep is based on the property being non-empty, so InlineDlfcnMethods=Disabled would still run the step and effectively behave like compatibility mode. Consider rejecting Disabled explicitly (throw) or treating it as empty/disabled so that it can’t accidentally enable the step.

Suggested change

if (Enum.TryParse<InlineDlfcnMethodsMode> (value, true, out var inlineDlfcnMode))

InlineDlfcnMethods = inlineDlfcnMode;

else if (string.Equals (value, "compatibility", StringComparison.OrdinalIgnoreCase))

InlineDlfcnMethods = InlineDlfcnMethodsMode.Compat;

else if (string.IsNullOrEmpty (value))

InlineDlfcnMethods = InlineDlfcnMethodsMode.Disabled;

else

if (string.IsNullOrEmpty (value))

InlineDlfcnMethods = InlineDlfcnMethodsMode.Disabled;

else if (string.Equals (value, "compatibility", StringComparison.OrdinalIgnoreCase))

InlineDlfcnMethods = InlineDlfcnMethodsMode.Compat;

else if (Enum.TryParse<InlineDlfcnMethodsMode> (value, true, out var inlineDlfcnMode)) {

if (inlineDlfcnMode == InlineDlfcnMethodsMode.Disabled)

throw new InvalidOperationException ($"Unknown InlineDlfcnMethods value: {value}");

InlineDlfcnMethods = inlineDlfcnMode;

} else

rolfbjarne requested a review from Copilot March 12, 2026 12:31

rolfbjarne added the copilot label Mar 12, 2026

Copilot started reviewing on behalf of rolfbjarne March 12, 2026 12:31 View session

rolfbjarne mentioned this pull request Mar 12, 2026

[net11.0] [tools/msbuild] Add InlineDlfcnMethodsStep as an opt-in custom linker step #24889

Draft

Copilot AI reviewed Mar 12, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne force-pushed the dev/rolf/inline-dlfcn branch from 1e92a98 to 4d6b334 Compare April 30, 2026 10:08

rolfbjarne requested a review from Copilot April 30, 2026 10:08

Copilot started reviewing on behalf of rolfbjarne April 30, 2026 10:09 View session

github-actions Bot requested changes Apr 30, 2026

View reviewed changes

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread tools/common/Frameworks.cs Outdated

Comment thread tools/common/Frameworks.cs Outdated

Comment thread tools/common/MachO.cs

This comment has been minimized.

Sign in to view

rolfbjarne requested a review from Copilot April 30, 2026 16:43

Copilot started reviewing on behalf of rolfbjarne April 30, 2026 16:44 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes


		The valid options are:

		* `compatibility`: Inlines dlfcn method calls but only creates native references for symbols used in `[Field]` attributes. This is more conservative and avoids link errors for symbols that don't exist at build time.

	* `compatibility`: Inlines dlfcn method calls but only creates native references for symbols used in `[Field]` attributes. This is more conservative and avoids link errors for symbols that don't exist at build time.
	* `compatibility`: Only inlines symbol usages backed by `[Field]` attributes. This is more conservative and avoids link errors for symbols that don't exist at build time.

	<OutputFile>$(DeviceSpecificIntermediateOutputPath)posttrim-info-compiled/%(Filename).o</OutputFile>
	<OutputFile>$(DeviceSpecificIntermediateOutputPath)posttrim-info-compiled/%(Arch)/%(Filename).o</OutputFile>

		var item = new Microsoft.Build.Utilities.TaskItem (outputPath);
		item.SetMetadata ("Arch", Architecture.ToLowerInvariant ());

-			var item = new Microsoft.Build.Utilities.TaskItem (outputPath);
-			item.SetMetadata ("Arch", Architecture.ToLowerInvariant ());
+			var architectures = Architecture.Split (',').Select (v => v.Trim ()).Where (v => v.Length > 0).ToArray ();
+			if (architectures.Length != 1) {
+				Log.LogError ("The '{0}' property must contain exactly one architecture for post-trimming processing, but was '{1}'.", nameof (Architecture), Architecture);
+				return;
+			}
+			var item = new Microsoft.Build.Utilities.TaskItem (outputPath);
+			item.SetMetadata ("Arch", architectures [0].ToLowerInvariant ());

Conversation

rolfbjarne commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Code Review Summary

Issues Found

Positive Highlights

Architecture Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 30, 2026

✅ [PR Build #703de17] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 30, 2026

✅ [PR Build #703de17] Build passed (Detect API changes) ✅

Uh oh!

github-actions Bot commented Apr 30, 2026 •

edited

Loading