Skip to content

Conversation

@gaius-qi
Copy link
Member

Description

This pull request removes the DownloadPersistentPiece and DownloadPersistentCachePiece RPC methods and their associated request/response message definitions from the Dfdaemon gRPC API. The changes affect both the protocol buffer definitions and the generated Go code, including the client/server interfaces and mocks. The version number in Cargo.toml is also bumped.

API and Protocol Buffer Cleanup

  • Removed the DownloadPersistentPiece and DownloadPersistentCachePiece RPC methods from the DfdaemonUpload service in dfdaemon.proto, along with their request and response message definitions. This streamlines the API by eliminating unused or deprecated functionality. [1] [2] [3] [4]
  • Updated the generated Go code in dfdaemon_grpc.pb.go to remove the corresponding client and server interface methods, handler functions, and service descriptor entries for the deleted RPCs. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

Test and Mock Updates

  • Removed mock methods and expected call definitions for the deleted RPCs from dfdaemon_mock.go, ensuring the mocks are consistent with the updated API. [1] [2] [3]

Version Update

  • Bumped the crate version in Cargo.toml from 2.2.10 to 2.2.11 to reflect the API changes.

Related Issue

Motivation and Context

@gaius-qi gaius-qi self-assigned this Jan 19, 2026
@gaius-qi gaius-qi added the enhancement New feature or request label Jan 19, 2026
@gaius-qi gaius-qi enabled auto-merge (squash) January 19, 2026 08:19
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 3feefef into main Jan 19, 2026
6 checks passed
@gaius-qi gaius-qi deleted the feature/piece branch January 19, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants