feat: remove DownloadPersistentPiece and DownloadPersistentCachePiece #614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the
DownloadPersistentPieceandDownloadPersistentCachePieceRPC methods and their associated request/response message definitions from the Dfdaemon gRPC API. The changes affect both the protocol buffer definitions and the generated Go code, including the client/server interfaces and mocks. The version number inCargo.tomlis also bumped.API and Protocol Buffer Cleanup
DownloadPersistentPieceandDownloadPersistentCachePieceRPC methods from theDfdaemonUploadservice indfdaemon.proto, along with their request and response message definitions. This streamlines the API by eliminating unused or deprecated functionality. [1] [2] [3] [4]dfdaemon_grpc.pb.goto remove the corresponding client and server interface methods, handler functions, and service descriptor entries for the deleted RPCs. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Test and Mock Updates
dfdaemon_mock.go, ensuring the mocks are consistent with the updated API. [1] [2] [3]Version Update
Cargo.tomlfrom2.2.10to2.2.11to reflect the API changes.Related Issue
Motivation and Context