feat(manager): add the seed_client_config to the SchedulerCluster #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlins
force-pushed
the
feat/seed-client-config
branch
from
e87dd57 to
eac95fe
Compare
Signed-off-by: chlins <[email protected]>
chlins
force-pushed
the
feat/seed-client-config
branch
from
eac95fe to
ef30b66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates the
SchedulerClusterAPI and related protobuf definitions to add support for a newseed_client_configfield, as well as improves the formatting and clarity of validation rules throughout the proto files. There is also a minor version bump for the Rust crate.API and Protobuf Enhancements:
seed_client_configfield (bytes) to theSchedulerClustermessage in the protobuf definitions (manager.proto,proto/manager.proto) and the corresponding Rust struct (src/manager.v2.rs). This enables clusters to have a dedicated configuration for seed clients. [1] [2] [3]Validation Rule Formatting and Clarity:
Reformatted and expanded inline validation rules in multiple proto message fields for better readability and maintainability, including breaking out rules for
ip,version,commit,idc,location,type,port, andnamefields into multi-line blocks. This affects messages such asGetSeedPeerRequest,ListSeedPeersRequest,UpdateSeedPeerRequest,DeleteSeedPeerRequest,GetSchedulerRequest,UpdateSchedulerRequest,ListSchedulersRequest,Application, andKeepAliveRequest. [1] [2] [3] [4] [5] [6] [7] [8] [9]Adjusted import order in
manager.protofor consistency and clarity.Validation Implementation:
SeedClientConfigfield in theSchedulerClustermessage, ensuring it is included in validation logic (currently with no additional rules).Versioning:
Cargo.tomlfrom2.2.13to2.2.14to reflect these changes.Description
Related Issue
Motivation and Context