feat(design-system): add DsSplitButton component [AR-54024]#347
Open
iromanchuk-dn wants to merge 9 commits intodrivenets:mainfrom
Open
feat(design-system): add DsSplitButton component [AR-54024]#347iromanchuk-dn wants to merge 9 commits intodrivenets:mainfrom
DsSplitButton component [AR-54024]#347iromanchuk-dn wants to merge 9 commits intodrivenets:mainfrom
Conversation
vpolessky-dn
reviewed
Apr 7, 2026
packages/design-system/src/components/ds-split-button/ds-split-button.module.scss
Show resolved
Hide resolved
vpolessky-dn
reviewed
Apr 7, 2026
vpolessky-dn
reviewed
Apr 7, 2026
packages/design-system/src/components/ds-split-button/ds-split-button.types.ts
Show resolved
Hide resolved
Collaborator
|
missing browser test fro the button |
…24-design-system-split-button
…24-design-system-split-button
vpolessky-dn
reviewed
Apr 8, 2026
| export type SplitButtonSize = (typeof splitButtonSizes)[number]; | ||
|
|
||
| export interface DsSplitButtonSlotProps { | ||
| button: Partial<DsButtonV3Props>; |
Collaborator
There was a problem hiding this comment.
type SplitButtonButtonProps = Pick<DsButtonV3Props, 'icon' | 'loading' | 'onClick' | 'aria-label' | 'className' | 'disabled'>;
vpolessky-dn
reviewed
Apr 8, 2026
| $divider-z-index: $highlighted-z-index + 1; | ||
| $divider-width: 1px; | ||
| $border-width: 1px; | ||
| $button-transition-duration: 0.15s; |
Collaborator
There was a problem hiding this comment.
transition standard is .2s
Collaborator
Author
There was a problem hiding this comment.
I made it aligned with DsButtonV3, it's important to have the same duration, because $button-transition-duration affects button right border.
…24-design-system-split-button
vpolessky-dn
approved these changes
Apr 9, 2026
…24-design-system-split-button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira | Figma
Depends on:
DsButtonV3[AR-52648] #350DsButtonV3[AR-52648] #353Showcase
Screen.Recording.2026-04-09.at.17.41.38.mov