chore(design-system): use Roboto font in the storybook internals [AR-65595]#508
Open
mmurawski-dn wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for drivenets-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mmurawski-dn
changed the title
| viteConfig.plugins = []; | ||
| } | ||
|
|
||
| viteConfig.plugins.push(vitePluginDesignSystem()); |
Collaborator
There was a problem hiding this comment.
I wonder, why did you remove this?
Collaborator
Author
There was a problem hiding this comment.
We are injecting the fonts via html files, and I thought it won't be needed anymore. Because this just injects the fonts into the storybook.
Seems like everything works without it. I will wait until Monday for Evyatars input 👍
Member
There was a problem hiding this comment.
Well, the idea of using this in storybook is mainly dogfooding
if there is an issue in storybook due to this, there might be an issue in the product as well
Why did you remove it? What's the issue you were seeing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://drivenets.atlassian.net/browse/AR-65595