Generate ObjC wrapper routes in spec_update workflow#469
Merged
Conversation
generate_base_client.py must be run twice: once for the Swift code and once with --objc for the SwiftyDropboxObjC wrapper. Without the second invocation the ObjC generated code goes stale and fails to compile when route signatures change (e.g. an error type is added). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_base_client.py --objcin addition to the plain invocation so theSwiftyDropboxObjCwrapper is regenerated alongside the Swift codeProblem
The spec update PR #467 fails to compile because the ObjC wrapper (
DBXCheckRoutes.swift) still referencesVoidSerializerfor thecheck/userecho route, while the regenerated Swift code now usesCheck.EchoErrorSerializer. The workflow only ran Swift generation, leaving the ObjC layer stale.Test plan
spec_updateand confirm the resulting PR compiles (Run Unit Tests passes)🤖 Generated with Claude Code