Disable swiftformat wrap and redundantInit rules to fix spec update timeout - #472
Merged
Merged
Conversation
These two rules trip SwiftFormat's internal per-rule timeout on the very large generated files (DBXTeamLog.swift is ~66k lines) when run on CI's slower runners, causing the spec update workflow's format step to fail with exit code 70 after ~40 minutes. Both rules are verified no-ops on the current generated output, so disabling them keeps formatting identical while letting the format step complete. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables the
wrapandredundantInitSwiftFormat rules, which trip SwiftFormat's internal per-rule timeout on the very large generated files on CI runners.Problem
After #471 added a SwiftFormat step to the spec update workflow, the "Format generated code" step ran for ~43 minutes and then failed with exit code 70:
DBXTeamLog.swiftis ~66k lines, and these two rules are superlinear on file size. On the slower CI runners they exceed SwiftFormat's built-in per-rule wall-clock timeout.Fix
Disable
wrapandredundantInit. Both are verified no-ops on the current generated output, so disabling them does not change any formatting — it only lets the format step finish.Test plan
swiftformat Source/SwiftyDropbox/Shared/Generated Source/SwiftyDropboxObjC/Shared/Generatedreports0/89 files formattedwith the updated config🤖 Generated with Claude Code