Exclude TeamLog files from swiftformat to fix spec update timeout#473
Merged
Merged
Conversation
TeamLog.swift (~68k lines) and DBXTeamLog.swift (~66k lines) cause the wrapArguments rule to exceed SwiftFormat's internal per-rule timeout on CI runners, failing the spec update workflow's format step with exit code 70 after ~70 minutes. Excluding these two generated files drops the format step from 11+ minutes per file to ~7 seconds for the entire generated tree, while keeping formatting applied to every other generated file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Excludes the two largest generated files from SwiftFormat so the spec update workflow's format step completes.
Problem
TeamLog.swift(~68k lines) andDBXTeamLog.swift(~66k lines) are by far the largest generated files. ThewrapArgumentsrule is superlinear in file size and exceeds SwiftFormat's internal per-rule timeout on CI runners — the spec update workflow ran ~70 minutes and then failed:There is no CLI flag to raise SwiftFormat's per-rule timeout.
Fix
Add the two
TeamLogfiles to the SwiftFormat--excludelist. These are machine-generated event-type dumps.Impact measured locally:
2 files skipped, 0 files changed on the currently-committed codeTest plan
swiftformat Source/SwiftyDropbox/Shared/Generated Source/SwiftyDropboxObjC/Shared/Generatedcompletes in ~7s, skips the 2 TeamLog files, and produces no diff on current master🤖 Generated with Claude Code