Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
=============================================
- Coverage 100.00% 99.19% -0.81%
- Complexity 578 626 +48
=============================================
Files 62 62
Lines 2005 2118 +113
=============================================
+ Hits 2005 2101 +96
- Misses 0 17 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change replaces the global "any prior
Workflow\\Exceptionlog" suppression with a replay probe.When an exception job arrives for a missing log index, we now:
probingmode that does not dispatch missing work or execute side effectsThis preserves the child-exception propagation fix from
#348while avoiding the later logging regression reported in#372.Root cause
1.0.70changed exception persistence from "one log per index" to "only the first exception log anywhere in the workflow". That deduped stale parallel sibling failures, but it also suppressed legitimate later exceptions after:Heuristics like "previous log is an exception" or "same replay timestamp" were still too coarse, because real workflows can catch one exception and then legitimately hit another failure without any neutral log in between.
What changed
probingreplay mode toWorkflowStub/WorkflowWorkflow\\Exceptionjobs(index, class)on the live pathValidation
Live sample-app repro with a real
queue:workworker:php artisan app:pr374-review retry --timeout=30php artisan app:pr374-review back-to-back --timeout=30php artisan app:pr374-review child --timeout=30Workflow repo tests:
php vendor/bin/phpunit --testsuite unit --filter ExceptionTestphp vendor/bin/phpunit --testsuite feature --filter ExceptionLoggingReplayTest