Skip to content

chore: remove Code Interpreter SDK sources migrated to the E2B monorepo - #332

Merged
mishushakov merged 1 commit into
mainfrom
devin/1787744810-remove-migrated-sdks
Aug 26, 2026
Merged

chore: remove Code Interpreter SDK sources migrated to the E2B monorepo#332
mishushakov merged 1 commit into
mainfrom
devin/1787744810-remove-migrated-sdks

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Removes js/ and python/, whose sources (including CHANGELOGs and READMEs) now live in the E2B monorepo as packages/code-interpreter-js / packages/code-interpreter-python — see e2b-dev/E2B#1768. Merge only after that PR lands, since @e2b/code-interpreter / e2b-code-interpreter are published from there afterwards.

The repo still ships chart_data_extractor (PyPI e2b-charts) and the code-interpreter-v1 template, both versioned through Changesets, so the pnpm/Changesets root stays — only the SDK-specific parts are cut:

  • workflows: js_tests, python_tests, performance_tests (it ran the Python SDK benchmark suite) and release_candidates (the js-rc/python-rc label pipeline) are deleted. pull_request.yml keeps build-templatecleanup-build-template (template still gets built and torn down on every PR) plus charts-tests; release.yml drops the @e2b/code-interpreter{,-python} preflight checks and the js-tests/python-tests gates, leaving charts → docker → template → release.
  • lint.yml installed Poetry deps in python/; it now does so in chart_data_extractor/, which is what pnpm run lint's remaining poetry run ruff script needs (template uses bare ruff, still pip-installed).
  • root: js/python out of pnpm-workspace.yaml, ESLint/Prettier devDependencies and configs and the esbuild override/onlyBuiltDependencies removed (nothing TypeScript is left), lockfile regenerated, bun dropped from .tool-versions.
  • release itinerary labels lose the two SDK entries so Slack lists only what this repo can still publish.

Two pending changesets (docs-subdomain-links, tag-e2b-links-with-utm) targeted only the migrated packages and are deleted; their README changes are already in the monorepo copies, but the changelog entries themselves are not carried over there — worth re-adding a changeset in e2b-dev/E2B if you want those lines in the published changelogs.

README gains a note pointing SDK issues and PRs at the monorepo.

Verified: actionlint clean, pnpm install --frozen-lockfile and pnpm changeset status (now bumping nothing) succeed, ruff check/ruff format --check clean in template/.

Link to Devin session: https://app.devin.ai/sessions/d0a0dbe7a0284be69afc52de32087953
Requested by: @mishushakov

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@cla-bot cla-bot Bot added the cla-signed label Aug 26, 2026
@mishushakov

Copy link
Copy Markdown
Member

rebase

@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/1787744810-remove-migrated-sdks branch from 2ae1a2a to 4b297e8 Compare August 26, 2026 12:35
@mishushakov
mishushakov marked this pull request as ready for review August 26, 2026 14:00
@mishushakov
mishushakov self-requested a review as a code owner August 26, 2026 14:00

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b297e8693

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/pull_request.yml

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — clean deletion commit with no dangling references.

What was reviewed: verified CI workflow wiring after removing js_tests/python_tests/performance_tests/release_candidates workflows — no remaining references to them in any workflow file; checked pnpm-workspace.yaml, package.json, and pnpm-lock.yaml for stale js/python entries — none found; confirmed release.yml and pull_request.yml needs: lists were updated consistently alongside the removed jobs; spot-checked lint.yml's Poetry step now correctly points at chart_data_extractor/ instead of the deleted python/.

Extended reasoning...

Overview

This commit deletes the entire js/ and python/ Code Interpreter SDK trees (source, tests, build/lint configs, README/CHANGELOG/LICENSE) since that code has migrated to the E2B monorepo, and trims root-level tooling (CI workflows, pnpm workspace config, ESLint/Prettier configs, .tool-versions) to match the reduced scope. The diff is almost entirely deletions (11795 removed, 16 added), with the only additions being pointer/whitespace-level edits to retained root files (README note, comment updates in .tool-versions, needs: list trims in workflow YAML).

Security risks

None. This is a pure removal of code and CI configuration; no new logic, secrets handling, or auth-relevant paths are introduced.

Level of scrutiny

Given the change is overwhelmingly deletion of code that has already been migrated elsewhere (per the linked companion PR e2b-dev/E2B#1768), the main risk is leaving the remaining repo in a broken/inconsistent state (dangling CI job references, stale workspace entries, orphaned lockfile entries). I focused verification there rather than reviewing the deleted source line-by-line, since it is being removed wholesale, not modified.

Other factors

I checked that no workflow file still references the deleted js_tests.yml/python_tests.yml/performance_tests.yml/release_candidates.yml, that pnpm-workspace.yaml no longer lists js/python while pnpm-lock.yaml has no leftover js/python/package.json entries, and that the needs: dependency lists in release.yml/pull_request.yml were updated in the same commit to match the removed jobs. Everything is internally consistent with the PR description, and the bug hunter reported no findings.

@mishushakov
mishushakov enabled auto-merge (squash) August 26, 2026 14:23
@mishushakov
mishushakov merged commit 0974bb9 into main Aug 26, 2026
12 checks passed
@mishushakov
mishushakov deleted the devin/1787744810-remove-migrated-sdks branch August 26, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant