chore: remove Code Interpreter SDK sources migrated to the E2B monorepo - #332
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
rebase |
2ae1a2a to
4b297e8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b297e8693
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Looks good — clean deletion commit with no dangling references.
What was reviewed: verified CI workflow wiring after removing js_tests/python_tests/performance_tests/release_candidates workflows — no remaining references to them in any workflow file; checked pnpm-workspace.yaml, package.json, and pnpm-lock.yaml for stale js/python entries — none found; confirmed release.yml and pull_request.yml needs: lists were updated consistently alongside the removed jobs; spot-checked lint.yml's Poetry step now correctly points at chart_data_extractor/ instead of the deleted python/.
Extended reasoning...
Overview
This commit deletes the entire js/ and python/ Code Interpreter SDK trees (source, tests, build/lint configs, README/CHANGELOG/LICENSE) since that code has migrated to the E2B monorepo, and trims root-level tooling (CI workflows, pnpm workspace config, ESLint/Prettier configs, .tool-versions) to match the reduced scope. The diff is almost entirely deletions (11795 removed, 16 added), with the only additions being pointer/whitespace-level edits to retained root files (README note, comment updates in .tool-versions, needs: list trims in workflow YAML).
Security risks
None. This is a pure removal of code and CI configuration; no new logic, secrets handling, or auth-relevant paths are introduced.
Level of scrutiny
Given the change is overwhelmingly deletion of code that has already been migrated elsewhere (per the linked companion PR e2b-dev/E2B#1768), the main risk is leaving the remaining repo in a broken/inconsistent state (dangling CI job references, stale workspace entries, orphaned lockfile entries). I focused verification there rather than reviewing the deleted source line-by-line, since it is being removed wholesale, not modified.
Other factors
I checked that no workflow file still references the deleted js_tests.yml/python_tests.yml/performance_tests.yml/release_candidates.yml, that pnpm-workspace.yaml no longer lists js/python while pnpm-lock.yaml has no leftover js/python/package.json entries, and that the needs: dependency lists in release.yml/pull_request.yml were updated in the same commit to match the removed jobs. Everything is internally consistent with the PR description, and the bug hunter reported no findings.
Summary
Removes
js/andpython/, whose sources (including CHANGELOGs and READMEs) now live in the E2B monorepo aspackages/code-interpreter-js/packages/code-interpreter-python— see e2b-dev/E2B#1768. Merge only after that PR lands, since@e2b/code-interpreter/e2b-code-interpreterare published from there afterwards.The repo still ships
chart_data_extractor(PyPIe2b-charts) and thecode-interpreter-v1template, both versioned through Changesets, so the pnpm/Changesets root stays — only the SDK-specific parts are cut:js_tests,python_tests,performance_tests(it ran the Python SDK benchmark suite) andrelease_candidates(thejs-rc/python-rclabel pipeline) are deleted.pull_request.ymlkeepsbuild-template→cleanup-build-template(template still gets built and torn down on every PR) pluscharts-tests;release.ymldrops the@e2b/code-interpreter{,-python}preflight checks and thejs-tests/python-testsgates, leaving charts → docker → template → release.lint.ymlinstalled Poetry deps inpython/; it now does so inchart_data_extractor/, which is whatpnpm run lint's remainingpoetry run ruffscript needs (templateuses bareruff, still pip-installed).js/pythonout ofpnpm-workspace.yaml, ESLint/Prettier devDependencies and configs and theesbuildoverride/onlyBuiltDependenciesremoved (nothing TypeScript is left), lockfile regenerated,bundropped from.tool-versions.Two pending changesets (
docs-subdomain-links,tag-e2b-links-with-utm) targeted only the migrated packages and are deleted; their README changes are already in the monorepo copies, but the changelog entries themselves are not carried over there — worth re-adding a changeset in e2b-dev/E2B if you want those lines in the published changelogs.README gains a note pointing SDK issues and PRs at the monorepo.
Verified:
actionlintclean,pnpm install --frozen-lockfileandpnpm changeset status(now bumping nothing) succeed,ruff check/ruff format --checkclean intemplate/.Link to Devin session: https://app.devin.ai/sessions/d0a0dbe7a0284be69afc52de32087953
Requested by: @mishushakov