Open
Conversation
Collaborator
Author
|
I have been stymied by inconsistent behaviour from the |
Collaborator
Author
|
I've added an integration test, which will fail until the validator is updated. |
Collaborator
Author
|
I am sticking with the I've updated the docker compose files, so that the profiles paths are provided, and to remove unnecessary environment variables for the celery worker. |
Collaborator
Author
|
@alexhambley, @elichad, @OliverWoolland - this is ready for review now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to provide extra profiles for the rocrate-validator to use. This is via the
profiles_pathso users will need to provide a directory containing all profiles (including their own), as the original profiles directory will not be used.When the user provides profiles already present, the validator will run, but just give a warning along the lines of:
Still to-do:
Side effects of this PR: