Allow transposing axes in 2d plots#150
Conversation
henrikjacobsenfys
added
[scope] enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #150 +/- ##
========================================
Coverage 97.84% 97.85%
========================================
Files 38 38
Lines 2599 2607 +8
Branches 449 452 +3
========================================
+ Hits 2543 2551 +8
Misses 32 32
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rozyczko
left a comment
rozyczko
left a comment
There was a problem hiding this comment.
Nothing major, some minor issues raised for consideration.
| If slicer or transpose_axes are not True or False. | ||
| """ | ||
|
|
||
| if self._binned_data is None: |
There was a problem hiding this comment.
you should probably query self.binned_data, since you're wrapping it earlier.
There was a problem hiding this comment.
this should presumably also be self.binned_data for consistency
| slicer: bool = False, | ||
| transpose_axes: bool = False, |
There was a problem hiding this comment.
Does this mean that transpose_axes is silently ignored when slicer=True? Maybe add a docstring in this case,
"Only applies when slicer=False"
There was a problem hiding this comment.
Yeah, it only applies to 2d plots without the slicer. When I add more coordinataes to the data I may have to revisit this, since a 2d slicer is possible. But I'll cross that bridge when I get to it
| ) -> None: | ||
| """ |
There was a problem hiding this comment.
Nope. You are returning fig.
Since this can be either plopp's figure or your own, maybe use Any?
There was a problem hiding this comment.
It's always a plopp figure, just sometimes a slicer. It seems they're the same type, so easy to type hint :)
2 participants
No description provided.