Skip to content

Rework diffusion models#191

Draft
henrikjacobsenfys wants to merge 13 commits into
developfrom
delta-lorentz
Draft

Rework diffusion models#191
henrikjacobsenfys wants to merge 13 commits into
developfrom
delta-lorentz

Conversation

@henrikjacobsenfys
Copy link
Copy Markdown
Member

First draft of these changes: #190

@henrikjacobsenfys henrikjacobsenfys added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] medium Normal/default priority labels May 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 39.56044% with 220 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.26%. Comparing base (fff0285) to head (a5eb112).

Files with missing lines Patch % Lines
...mics/sample_model/diffusion_model/delta_lorentz.py 22.03% 184 Missing ⚠️
...mple_model/diffusion_model/diffusion_model_base.py 60.56% 19 Missing and 9 partials ⚠️
src/easydynamics/analysis/fit_binding.py 0.00% 2 Missing and 2 partials ⚠️
...iffusion_model/brownian_translational_diffusion.py 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #191      +/-   ##
===========================================
- Coverage    98.42%   92.26%   -6.16%     
===========================================
  Files           50       51       +1     
  Lines         3175     3492     +317     
  Branches       576      642      +66     
===========================================
+ Hits          3125     3222      +97     
- Misses          26      233     +207     
- Partials        24       37      +13     
Flag Coverage Δ
integration 44.93% <34.06%> (-1.25%) ⬇️
unittests 92.12% <38.18%> (-6.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] medium Normal/default priority [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider if DiffusionModel should store Q internally Make sure diffusion models generate the correct dependent parameters

1 participant