docs: advanced config properties#2816
Open
deerskindoll wants to merge 1 commit intoeclipse-che:mainfrom
Open
Conversation
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
|
🎊 Navigate the preview: 🎊 |
Member
|
@deerskindoll can we have the preview link for those changes? |
ibuziuk
reviewed
Dec 6, 2024
Member
ibuziuk
left a comment
ibuziuk
left a comment
There was a problem hiding this comment.
@tolusha @vinokurig please, review
I'm a bit afraid that a lot of options might be obsolete / misleading if we re-enable automatic generation
tolusha
approved these changes
Dec 9, 2024
Contributor
|
I agree with @ibuziuk, there are a lot of outdated configurations related to the old workspace architecture in the https://github.com/eclipse-che/che-server/blob/main/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties |
vinokurig
requested changes
Dec 10, 2024
Contributor
vinokurig
left a comment
vinokurig
left a comment
There was a problem hiding this comment.
depends on eclipse-che/che#21411
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
re-added advanced content properties table
What issues does this pull request fix or reference?
eclipse-che/che#23130
Specify the version of the product this pull request applies to
main
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.