Update and consume third-party content #648
Conversation
No changes, but reforatted with current version of PDE This makes future edits easier as there will be no unrelated edits on the file.
These don't hurt anything to exist, but getting rid of them removes a warning.
Will parent commits moving or removing dependencies this commit is the completion of eclipse-embed-cdt#453 Fixes eclipse-embed-cdt#453
To be able to use location type Maven in target file we need a more recent Tycho version. Instead of updating to latest (5.x) version of Tycho, we limit to 3.x version so that we can maintain compatibility with older Eclipse target platform. Embed CDT uses 2020-09 as target platform. The build requires a newer Java version, but the built artifacts continue to run in Java11+ on Eclipse 2020-09+. Fixes eclipse-embed-cdt#646
As we consume directly from Maven Central for third-party dependencies we need to resign content with PGP to allow installation without signing errors. Note that this only works for recent-ish versions of Eclipse. Installing in older versions will cause unsigned content warnings. Users are recommended to use latest/recent Eclipse versions to be fully supported and ISVs are responsible to to maintain and update as needed.
We need Java 11 (for its JDK) and Java 21 for build tools.
| <goal>sign-p2-artifacts</goal> | ||
| </goals> | ||
| <configuration> | ||
| <keyname>F5CBCFD82F07D82E</keyname> |
There was a problem hiding this comment.
For this to build & run on Jenkins we need https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/7079 to be completed and this line updated with the project's public key which will be announced in that helpdesk issue.
If the helpdesk issue is not resolved fast enough we can disable pgp signing for M2 this week.
|
@ilg-ul LMK if this looks good to you - without any objections I will merge and build a milestone for SimRel sometime Mon-Wed this week. There is a version bump that needs to happen before then AFAICT - because I haven't changed any Eclipse or Java version dependencies, we can do a fairly minimal version bump, e.g. 6.6.1 -> 6.7.0 |
ilg-ul
left a comment
ilg-ul
left a comment
There was a problem hiding this comment.
Wow! You fixed a lot of things and probably brought it in line with the latest Eclipse build details.
I don't understand most of the details, but I have no objections.
|
Please let me know when you have a set of Mac binaries that I can test. |
2 participants
This PR is an omnibus PR that updates the build to no longer embed third-party jars, allowing them to be updated in the "normal" flow of the rest of SimRel contributing projects.
Included is the needed updates to build with Java 21, but still produce Java 11 jars. As such we update to Tycho 3 which allows the needed new features, but still allows build and run against Eclipse 2020-09.
A future exercise could be to update to more recent Tycho and cutoff support for older Eclipse versions. ref: #646 (comment)
Fixes #646
Fixes #453