Use Rectangle.ofFloat for bounds in WM_PAINT to avoid rounding issues #2933
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resizing or expanding scrollable with styled text (e.g. Git revision information), the width of the newly painted region can be small such that they are non-zero in pixels but rounded down to zero in points (after pixelToPoint call). This causes StyledText::handlePaint to skip drawing due to the below check , resulting in visible artifact lines.
if (event.width == 0 || event.height == 0) return;linkUsing float-based bounds preserves these non-zero regions from being rounded to zero in points and prevents missed paint operations during resize.
Steps to reproduce:
(Originally posted by @HeikoKlare in vi-eclipse/Eclipse-Platform#560)