[Win32] Replace ImageHandle class hierarchy with interfaces #2943
+66
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
imagehandle-interfaces
branch
from
ffde787 to
e27802b
Compare
Contributor
HeikoKlare
force-pushed
the
imagehandle-interfaces
branch
from
e27802b to
b7df12b
Compare
amartya4256
reviewed
Jan 9, 2026
Contributor
amartya4256
left a comment
amartya4256
left a comment
There was a problem hiding this comment.
The changes look good and add a better abstraction to the class. I have added a small suggestion. Overall I was questioning if the name of the interfaces are still relevant or could be made clearer.
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
To ensure proper restricted access to specific functionality of Image's internal ImageHandle class, a hierarchy of classes with different visibilities is currently used. To better express that there is just a single type to instantiate and that access restriction is supposed to be done by only providing specific methods to specific consumers, this change replaces the existing class hierarchy with a single implementation class and a conversion of the existing other classes with interfaces. It also further restricts access to several methods of ImageHandle (zoom(), bounds(), isDisposed()) that are not required to be public.
HeikoKlare
force-pushed
the
imagehandle-interfaces
branch
from
b7df12b to
c772f7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure proper restricted access to specific functionality of Image's internal ImageHandle class, a hierarchy of classes with different visibilities is currently used. To better express that there is just a single type to instantiate and that access restriction is supposed to be done by only providing specific methods to specific consumers, this change replaces the existing class hierarchy with a single implementation class and a conversion of the existing other classes with interfaces. It also further restricts access to several methods of ImageHandle (zoom(), bounds(), isDisposed()) that are not required to be public.