Cleanup InputReadJob related ProcessConsole code#2553
Merged
iloveeclipse merged 1 commit intoeclipse-platform:masterfrom Mar 5, 2026
Merged
Cleanup InputReadJob related ProcessConsole code#2553iloveeclipse merged 1 commit intoeclipse-platform:masterfrom
iloveeclipse merged 1 commit intoeclipse-platform:masterfrom
Conversation
- Made console stream fields final for ProcessConsole and InputReadJob - closeStreams() should first set fStreamsClosed to true before closing the stream, to give the InputReadJob a chance to exist without error - InputReadJob should consider that stream could be closed via canceling() - don't log IO errors from InputReadJob if we know that stream is closed Fixes eclipse-platform#1033
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1033