Add user manuals for time module - #148
Conversation
It includes - An overall architecture introduction and a guide for choosing the right clock. - A detailed API description covering basic usage, lifecycle management, advanced subscriptions, and unit-testing patterns. - A dedicated integration guide for system integrators. - A troubleshooting guide for diagnosing common runtime issues.
…rib/score_inc_time into docs/ryan-steel-LudwigAtBosch-user-manual
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
bf05f16 to
d6cb760
Compare
fc5eec7 to
1345156
Compare
1345156 to
70c6f70
Compare
| <Module sphinx documentation template snippets for the module. The directives and their parameters | ||
| should be updated according to the module and it's components.> |
There was a problem hiding this comment.
I think, this needs to be filled by something meaningful ...
There was a problem hiding this comment.
Should we have those empty folders? Imho we should leave them away - especially those marked as optional.
There was a problem hiding this comment.
Remove - see comment for config folder
| Polling the Current Time | ||
| ------------------------ | ||
|
|
||
| This method involves actively requesting the current time from the ``score::time`` framework. It is the simplest way to get a timepoint when needed. |
There was a problem hiding this comment.
| Polling the Current Time | |
| ------------------------ | |
| This method involves actively requesting the current time from the ``score::time`` framework. It is the simplest way to get a timepoint when needed. | |
| Polling the Current Vehicle Time | |
| -------------------------------- | |
| This method involves actively requesting the current vehicle time from the ``score::time`` framework. It is the simplest way to get a timepoint when needed. |
| Adapting for Your Application | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
| Adapting for Your Application | |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |
| Adapting Your Application | |
| ~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
What about subfolders module/release and verification_report (if we want to have empty folders)?
|
|
||
| Time Component | ||
| ============== | ||
|
|
There was a problem hiding this comment.
Maybe we should have a short sentence here and in the others, what these components are for, each
| The following argument is available to configure the ``TimeSlave`` at runtime: | ||
|
|
||
| .. list-table:: | ||
| :widths: 25 15 60 | ||
| :header-rows: 1 | ||
|
|
||
| * - Argument | ||
| - Overrides | ||
| - Description | ||
| * - ``-i, --interface <name>`` | ||
| - ``iface_name`` | ||
| - **Mandatory Runtime Parameter.** Specifies the Ethernet network interface. Although the internal default is "emac0", this **must** be set correctly at runtime to match the target hardware. |
There was a problem hiding this comment.
I think, we should remove this
- It's not yet merged
- I propose not to merge it, as gordon9901 will provide a json-based config, soon: feat: add TimeDaemon CIT with pip hub infrastructure #122
| The following argument is available to configure the ``TimeSlave`` at runtime: | |
| .. list-table:: | |
| :widths: 25 15 60 | |
| :header-rows: 1 | |
| * - Argument | |
| - Overrides | |
| - Description | |
| * - ``-i, --interface <name>`` | |
| - ``iface_name`` | |
| - **Mandatory Runtime Parameter.** Specifies the Ethernet network interface. Although the internal default is "emac0", this **must** be set correctly at runtime to match the target hardware. | |
| The following argument is available to configure the ``TimeSlave`` at runtime: <tbd> |
| ./time_slave --interface eth1 | ||
|
|
||
| .. attention:: | ||
| The command-line parsing is currently incomplete. To change parameters other than the interface name, you must modify the default values in the ``GptpEngineOptions`` structure and recompile the application. A comprehensive configuration mechanism (e.g., via a JSON file) is planned for future versions. |
There was a problem hiding this comment.
| ./time_slave --interface eth1 | |
| .. attention:: | |
| The command-line parsing is currently incomplete. To change parameters other than the interface name, you must modify the default values in the ``GptpEngineOptions`` structure and recompile the application. A comprehensive configuration mechanism (e.g., via a JSON file) is planned for future versions. | |
| ./time_slave | |
| .. attention:: | |
| The runtime configuration is currently incomplete. To change parameters, you must modify the default values in the ``GptpEngineOptions`` structure and recompile the application. A comprehensive configuration mechanism (e.g., via a JSON file) will come soon. |
| @@ -19,9 +19,3 @@ time_slave Component | |||
| :maxdepth: 1 | |||
|
|
|||
| component_classification | |||
|
|
||
| .. _manual_time_api_usage: | ||
|
|
||
| API Usage: Accessing Vehicle Time |
There was a problem hiding this comment.
I see here the Vehicle Time only.
but idea was,the module API provides the API to access the supported time bases, like chrono, hrlsc abd vehicle time
|
|
||
| .. _ components:: | ||
|
|
||
| Components |
There was a problem hiding this comment.
I don't see the components subfolder in the folder structure document
https://eclipse-score.github.io/score/main/contribute/general/folder.html
so, my question is why it is still here and do we really need it?
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
|
|
||
| Safety Manual |
There was a problem hiding this comment.
Do we really need it now?
it is empty anyway and not clarified if we will need it.
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
|
|
||
| Security Manual |
There was a problem hiding this comment.
Do we really need it now?
it is empty anyway and not clarified if we will need it.
There was a problem hiding this comment.
you delete the file, but put the safety manual in manuals subfolder. I think it shall be here then.
the simuilar with security
Improvement
Adds user-facing documentation for S-CORE time module and its key components.
Description
Related Ticket
closes #125 (improvement ticket)