Skip to content

Conversation

@ArthurHeymans
Copy link
Contributor

  • I added a entry in changelog under unreleased section.

Add git worktree support for workspace and config discovery

  • Add new eca.git namespace with utilities for detecting git roots and worktrees
  • Update config loading to fall back to git root when no workspace folders provided
  • Update initialize handler to use git root as workspace folder fallback
  • Fix test isolation by mocking config/get-env in provider-api-key test
  • Add comprehensive tests for git utilities and config fallback behavior

Signed-off-by: Arthur Heymans [email protected]

- Add new eca.git namespace with utilities for detecting git roots and worktrees
- Update config loading to fall back to git root when no workspace folders provided
- Update initialize handler to use git root as workspace folder fallback
- Fix test isolation by mocking config/get-env in provider-api-key test
- Add comprehensive tests for git utilities and config fallback behavior

Signed-off-by: Arthur Heymans <[email protected]>
@zikajk
Copy link
Member

zikajk commented Dec 18, 2025

What problem does it solve? Thank you

@ArthurHeymans
Copy link
Contributor Author

What problem does it solve? Thank you

I have a git worktree inside a git directory, let's say .worktree/feature_x. Previously eca would then operate on the root worktree rather than the feature_x worktree.

@ericdallo
Copy link
Member

Please create issues before PRs for things we should discuss before, this avoids re-work
Not sure I agree with this one, workspace roots are client responsibilities for some reasons, because each client handle workspace roots diferently.
I wonder if one can solve that starting eca with different workspace roots like it already supports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants