Polish Nav V2 sidebar chrome and API method badges - #3846
Open
itsalexcm wants to merge 10 commits into
Open
Conversation
Keeps the tree building on SDKs that do not yet support the with-expression collection initializer form used elsewhere in the repo. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Fixes viewport gaps under the elastic-nav shell, scroll/search/back chrome, label spacing, and current-page matching for dotted relative URLs so islands like Extend stay highlighted after rebuild and hx-boost. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Surfaces single-method glyphs and a multi-operation badge in the API sidebar so operation rows match the rest of the Nav V2 chrome. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This reverts commit 1f6fa63.
CI treats IDE0028 as errors, so collection expressions must keep the with-comparer form. Also remove the unused size binding that failed ESLint. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
itsalexcm
force-pushed
the
experiment/nav-fixes
branch
from
August 12, 2026 13:19
0b4e9ed to
db22982
Compare
dotnet format had added parameterless RequiresDynamicCode/RequiresUnreferencedCode attributes that do not compile on the current SDK. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Restore Nav V2 HTMX segment helpers on URL strategies, wire NavigationViewModel into nav render tests, fix hub/whats-new product links, and update synthetics for the Nav V2 get-started IA. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Align assembler link tests with body-boost, restore nav render cache identity, register hub syntax pages in the docset TOC, and set hx-swap=none with select-oob so Nav V2 sidebar navigation updates content. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Quoted hx-* attributes were HTML-encoded by Razor to ", so sidebar clicks pushed the URL without swapping content. Keep values unquoted, add hx-swap=none, and list testing/products pages in the docset TOC. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR tightens Nav V2 sidebar polish so the panel feels intentional under both isolated serve and the assembler elastic-nav shell: fewer layout gaps, clearer sticky chrome, reliable “you are here” highlighting, and API rows that match the same visual language.
Design / UX improvements (in this PR)
Use this list in review — everything below is intentional and should be noticeable in
:3000(isolated) and:4000(assembler).Layout & sticky chrome
#pages-navheight flex fix)top: 8px), pinned to the menu host rather than floating oddly in the treeSearch & Back (island chrome)
16pxpadding + light bottom border (#e3e8f2) so it reads as chrome, not part of the treemin-height: 32px, inline padding,8pxradius)5px) so it aligns with Back / row rhythmLabels, hierarchy & active state
24px) so section breaks breathe#516381) for text (chevron stays neutral)/./…) — e.g. Extend → Kibana deep pages stay highlighted after load and hx-boostlabel:nodes and API tag-group headings render the same non-clickable heading chromeAPI sidebar
Explicitly not in this PR
Call these out so reviewers don’t hunt for them:
index.mdlandings (overview is still the island landing URL, but not listed as a.currenttree row)label: ───separators, nested labels under clickable groups in deploy-manage) — those come fromnavigation-v2.yml, not CSS bugsfindability/alexcerezoTest plan
FEATURE_NAV_V2=true, :3000): no bottom gap; Search/Back borders align; scroll buttons under chrome/./URLs)