Remove orphaned shape data at boot#3860
Open
magnetised wants to merge 1 commit intomagnetised/shape-db-exclusive-modefrom
Open
Remove orphaned shape data at boot#3860magnetised wants to merge 1 commit intomagnetised/shape-db-exclusive-modefrom
magnetised wants to merge 1 commit intomagnetised/shape-db-exclusive-modefrom
Conversation
If the number of valid shapes is 0, then just efficiently remove the shape data directory entirely, forcing a re-creation. In the case of an ephemeral shape db this will reset the shape data alongside the reset of the shape db.
magnetised
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## magnetised/shape-db-exclusive-mode #3860 +/- ##
======================================================================
- Coverage 87.20% 87.07% -0.13%
======================================================================
Files 25 25
Lines 2314 2314
Branches 583 579 -4
======================================================================
- Hits 2018 2015 -3
- Misses 294 297 +3
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the number of valid shapes is 0, then just efficiently remove the shape data directory entirely, forcing a re-creation. In the case of an ephemeral shape db this will reset the shape data alongside the reset of the shape db.