-
Notifications
You must be signed in to change notification settings - Fork 1k
Songino -> Battery storage #8355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
parsers/MN.py
Outdated
| prod_mix.add_value("solar", data["solar"]) | ||
| prod_mix.add_value("wind", data["wind"]) | ||
| storage_mix = StorageMix() | ||
| storage_mix.add_value("battery", data["battery_storage"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned this on the other PR as well but I think we need to invert the value here for it to be correct.
Negative is discharge and positive charge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if it is charging now and the value is positive, and charging is positive, then we should not invert, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that's the question. Is it charging or discharging? Unless the dashboard has both positive and negative values I would assume they always show discharge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually the charging pattern is something like charging at night, discharging in the morning, charge mid day, discharge afternoon to meet normal consumption patterns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait a couple of hours and see if the value turns negative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see later how it changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have inverted it, it makes more sense.
Invert battery


Issue
Adding Battery to Mongolian parser.
website: https://ndc.energy.mn/
Currently: it is the afternoon in Mongolia, so I assume it is charging.

So the value battery_storage is 12.7MW