Skip to content

Conversation

@PaulRoms
Copy link
Contributor

Issue

Adding Battery to Mongolian parser.
website: https://ndc.energy.mn/

Currently: it is the afternoon in Mongolia, so I assume it is charging.
image

So the value battery_storage is 12.7MW

@PaulRoms PaulRoms requested a review from VIKTORVAV99 as a code owner August 14, 2025 09:45
@PaulRoms PaulRoms requested review from a team and annaib00 August 14, 2025 09:46
@github-actions github-actions bot added parser python Pull requests that update Python code labels Aug 14, 2025
parsers/MN.py Outdated
prod_mix.add_value("solar", data["solar"])
prod_mix.add_value("wind", data["wind"])
storage_mix = StorageMix()
storage_mix.add_value("battery", data["battery_storage"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned this on the other PR as well but I think we need to invert the value here for it to be correct.

Negative is discharge and positive charge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if it is charging now and the value is positive, and charging is positive, then we should not invert, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's the question. Is it charging or discharging? Unless the dashboard has both positive and negative values I would assume they always show discharge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually the charging pattern is something like charging at night, discharging in the morning, charge mid day, discharge afternoon to meet normal consumption patterns.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait a couple of hours and see if the value turns negative

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see later how it changes!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have inverted it, it makes more sense.

@PaulRoms
Copy link
Contributor Author

18:00
image

@PaulRoms
Copy link
Contributor Author

image

@github-actions github-actions bot added the tests label Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parser python Pull requests that update Python code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants