-
Notifications
You must be signed in to change notification settings - Fork 1k
chore(configs): Aggregate CL #8450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| @@ -0,0 +1,16 @@ | |||
| country: CL | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@PaulRoms told me we had monthly/yearly data through IEA/EMBER.
How do we want to handle the country-level flowtraced data ? Through sub zones aggregation or through country-level data (which we don't currently handle in the flowtracing algo) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now it only works through the subZones as you are mentioning.
I think we need to be careful about changing that because for some aggregated zones we are fetching both country level data and subzone data (could be useful for the validation project though).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that we have to be careful about changing this too 👍
Since some zone have no data, sub zones aggregation won't work.
If we want to compute CL aggregate from the only the zone that we currently have data, we might want to add the bypassedzones here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we can do that, I thought we would use GPZD on the missing subzones but maybe I misunderstood and we only have top level data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the subZone for Chile?
It might be simpler to only have CL and no subzone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me ask via Slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
South Chile has very few inhabitants. https://upload.wikimedia.org/wikipedia/commons/b/b7/Cl-cities.png
My gut feeling would say to aggregate the country with zones for which we have data.
But I think we would compare EMBER/IEA data with what we currently have and decide based on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because yeah, we only have country level yearly/monthly data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we do GPZD - measured data = remaining zones and combine them into one subzone?
Then we would have a mix of measured and GPZD subzones and the parent would be a composite with the best of both worlds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are doing it for Malasia, it is true!
Aggregates CL by creating a top level config and creating a exchange config for the country level exchange.
I'll follow up with updating the translations in the new app.