build(dev-deps): drop tsx#1908
Merged
Merged
Conversation
dsanders11
force-pushed
the
build/drop-tsx
branch
from
e070718 to
907a069
Compare
erikian
approved these changes
Apr 23, 2026
erickzhao
approved these changes
Apr 23, 2026
ckerr
approved these changes
Apr 23, 2026
erickzhao
reviewed
Apr 23, 2026
| key: v1-electron-cache-${{ matrix.os }} | ||
| - name: Download Electron binaries | ||
| run: yarn tsx test/ci/download-electron.ts | ||
| run: node test/ci/download-electron.ts |
Member
There was a problem hiding this comment.
btw i think anything that touches .github is pending infra wg approval now so we'd have to wait to merge
MarshallOfSound
approved these changes
May 13, 2026
jkleinsc
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
We can drop this in favor of type-stripping since it's only used in CI.