Fix styling issue when using EW modules #31533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/compound-css-order
branch
from
626dab0 to
61acff3
Compare
florianduros
force-pushed
the
florianduros/compound-css-order
branch
from
46f497c to
bd87c08
Compare
t3chguy
reviewed
Dec 12, 2025
florianduros
force-pushed
the
florianduros/compound-css-order
branch
from
181a647 to
3c6d7ec
Compare
florianduros
force-pushed
the
florianduros/compound-css-order
branch
from
3c6d7ec to
7425d4d
Compare
florianduros
force-pushed
the
florianduros/compound-css-order
branch
from
7b43521 to
f05f296
Compare
florianduros
force-pushed
the
florianduros/compound-css-order
branch
from
3d9938a to
4249fe6
Compare
florianduros
force-pushed
the
florianduros/compound-css-order
branch
from
4249fe6 to
696aa77
Compare
t3chguy
approved these changes
Dec 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
Downstream playwright tests have no known flakes, so just rerunning continually is unlikely to change the outcome :D |
Member
Author
|
@t3chguy there are flakes, i have them in my others PRs.... |
Member
|
The changes I see in the playwright report for the latest run look like changes caused by compound styles no longer being applied |
Member
|
But if you are seeing flakes please link to the flake issues |
Member
Author
|
Oh nvm, the flakes i am seeing are not downstreamed (create-room), i'll take a look at the errors on downstream |
This was referenced Dec 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Dec 18, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an EW module uses compound, compound style sheet is applied a second time after EW style sheets. This is causing styling issues. This PR moves compound import at the end and fixes the style overrides (where EW override compound css).
Closes https://github.com/element-hq/wat-internal/issues/345
Needs element-hq/element-modules#163 element-hq/element-modules#164 element-hq/element-modules#165 element-hq/element-modules#166 element-hq/element-modules#167 element-hq/element-modules#167