Merged
Conversation
0af8628 to
0323d9d
Compare
Member
Author
|
This should be ready for review now. You can look at the individual commits for easier review. The first one is the same as #523. |
zeebok
approved these changes
Mar 29, 2026
Contributor
zeebok
left a comment
There was a problem hiding this comment.
Looks good to me. Let me know if I need to re-review anything after fixing conflicts
0323d9d to
aac5bee
Compare
aac5bee to
e7eb6ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of #523 and allows us to provide a listmodel of objects and bind them to the itemgroup similar to how we bind listmodels to listboxes.
This has a few advantages: