feat: ensure all handlers explicitly set HTTP status codes#193
Merged
feat: ensure all handlers explicitly set HTTP status codes#193
Conversation
Wrap ResponseWriter in ServeHTTP with a statusResponseWriter that guarantees WriteHeader is always called explicitly. This allows observability middleware to reliably capture status codes, which was not possible when handlers relied on net/http's implicit 200 on first Write call. The wrapper also guards against duplicate WriteHeader calls by ignoring subsequent invocations after the first. Closes #183 Co-Authored-By: iwarapter <iwarapter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap ResponseWriter in ServeHTTP with a statusResponseWriter that guarantees WriteHeader is always called explicitly. This allows observability middleware to reliably capture status codes, which was not possible when handlers relied on net/http's implicit 200 on first Write call.
The wrapper also guards against duplicate WriteHeader calls by ignoring subsequent invocations after the first.
Closes #183