Add Read the docs files. Before they were auto generated#213
Merged
Add Read the docs files. Before they were auto generated#213
Conversation
Contributor
Reviewer's GuideAdds an explicit Sphinx configuration and Read the Docs config to version control so docs are no longer auto-generated, and scaffolds the documentation index and requirements files. Flow diagram for ReadTheDocs build process using new config filesflowchart TD
S[New commit pushed] --> C[.readthedocs.yaml detected by ReadTheDocs]
C --> B[Create Python 3.11 environment]
B --> R[Install dependencies from documentation/requirements.txt]
R --> L[Load Sphinx configuration from documentation/conf.py]
L --> P[Parse source files including documentation/index.rst]
P --> G[Generate HTML using sphinx_rtd_theme]
G --> D[Publish built docs to ReadTheDocs]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- documentation/requirements.txt appears to contain a copy of the Read the Docs YAML config rather than Python package requirements; it should instead list the Sphinx extensions/themes used (e.g., myst_parser, sphinx_rtd_theme) in standard pip requirements format.
- documentation/index.rst is currently empty; consider adding at least a minimal toctree or landing content so that Sphinx has a meaningful root document to render.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- documentation/requirements.txt appears to contain a copy of the Read the Docs YAML config rather than Python package requirements; it should instead list the Sphinx extensions/themes used (e.g., myst_parser, sphinx_rtd_theme) in standard pip requirements format.
- documentation/index.rst is currently empty; consider adding at least a minimal toctree or landing content so that Sphinx has a meaningful root document to render.
## Individual Comments
### Comment 1
<location> `documentation/conf.py:21` </location>
<code_context>
+ ".md": "markdown",
+}
+
+master_doc = "index"
+
+# -- HTML output -------------------------------------------------------------
</code_context>
<issue_to_address>
**suggestion:** Consider using `root_doc` instead of `master_doc` for newer Sphinx versions.
To keep this config forward-compatible with newer Sphinx versions, use `root_doc = "index"` (or the appropriate root) instead of `master_doc`.
```suggestion
# Root document (Sphinx 2.0+)
root_doc = "index"
# Backwards compatibility for older Sphinx versions
master_doc = root_doc
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
trispera
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Configure Sphinx and Read the Docs to build project documentation from a new documentation directory.
Build:
Documentation: