Drop elixir version requirement to 1.15 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polvalente
reviewed
Nov 14, 2025
| defp deps do | ||
| [ | ||
| {:protobuf, "~> 0.12"}, | ||
| {:jason, "~> 1.4"}, |
There was a problem hiding this comment.
Why is this dependency being added?
Contributor
Author
There was a problem hiding this comment.
This is mentioned in the description, but protobuf uses either Jason or the built-in JSON. For versions under 1.18, Jason has to be used.
There was a problem hiding this comment.
Ah ok. I think there's a typo/autocorrect in the description. It all makes sense now.
There was a problem hiding this comment.
Ah ok. I think there's a typo/autocorrect in the description. It all makes sense now.
Contributor
Author
There was a problem hiding this comment.
Ah sorry, I've just been dealing with Jiffy 😅
polvalente
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grpc library only requires version 1.15, but this requires 1.18.
In order to suppress this warning in the main library, this library should require the same. This unfortunately means pulling in Jiffy on all elixir versions (so that the protobuf library can encode JSON), but that's fine.